1924240 - Harmonize parent / child widget handling across platforms.

Status: RESOLVED FIXED

(Core :: Widget, task, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1924240 - Simpler parent / child setup in nsCocoaWindow.mm. r=#mac-reviewers!

Try seems happy with this.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1924240 - More common parent handling between Linux and Windows. r=#win-reviewers!,stransky!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1924240 - Simplify nsWindow::IsTopLevelWidget() on Windows. r=#win-reviewers!

No reason to have a separate member here.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1924240 - Pack android nsWindow fields better and clean-up initialization. r=#geckoview-reviewers!

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1924240 - Make android widget handling similar to all other platforms. r=#geckoview-reviewers!,m_kato

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3613fc672c50
Simpler parent / child setup in nsCocoaWindow.mm. r=mac-reviewers,bradwerth

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7652535fcdac
Remove an assert that doesn't always hold.

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3613fc672c50
https://hg.mozilla.org/mozilla-central/rev/7652535fcdac

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff7cbc693154
Pack android nsWindow fields better and clean-up initialization. r=geckoview-reviewers,m_kato
https://hg.mozilla.org/integration/autoland/rev/6e19fcee135d
Make android widget handling similar to all other platforms. r=m_kato,geckoview-reviewers

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ff7cbc693154
https://hg.mozilla.org/mozilla-central/rev/6e19fcee135d

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1924240 - Devirtualize parent handling. r=#mac-reviewers!,#win-reviewers!,#geckoview-reviewers!,stransky!

Move mParent to nsIWidget.h along with kids and so on. Instead of
ReparentNativeWidget add a more general DidChangeParent method.

Make mParent weak to prevent cycles. These are broken on Destroy() but
it feels kinda silly, and we were inconsistent before I started this
effort so pretty sure it can be done.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66cf65217104
More common parent handling between Linux and Windows. r=stransky,win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/3c9fb8f4a18e
Simplify nsWindow::IsTopLevelWidget() on Windows. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/7cec75426e72
Devirtualize parent handling. r=mac-reviewers,win-reviewers,geckoview-reviewers,bradwerth,m_kato,rkraesig
https://hg.mozilla.org/integration/autoland/rev/4d75277ebe4e
apply code formatting via Lando

Comment 13

[Cosmin Sabou [:CosminS]]

Backed out 4 changesets (Bug 1924240) for causing failures related to nsBaseWidget.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=4d75277ebe4e3a9b841917cd368db0a12b5712fe&selectedTaskRun=MnPxXTy8TxmrHoP9IT_Twg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=479418634&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/fd6962fbe63e86aad4b8e97e457f370d7908244c

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2f3ba3fdba0
More common parent handling between Linux and Windows. r=stransky,win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/046b408b7544
Simplify nsWindow::IsTopLevelWidget() on Windows. r=win-reviewers,rkraesig
https://hg.mozilla.org/integration/autoland/rev/d2c236c5df45
Devirtualize parent handling. r=mac-reviewers,win-reviewers,geckoview-reviewers,bradwerth,m_kato,rkraesig

Comment 15

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a2f3ba3fdba0
https://hg.mozilla.org/mozilla-central/rev/046b408b7544
https://hg.mozilla.org/mozilla-central/rev/d2c236c5df45