Closed Bug 1924332 Opened 2 years ago Closed 1 year ago

Use eventListener instead of addhook nsICommandParams for chat window input paste

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.20)

Attachments

(1 file)

A multi-line paste into the textbox input was special-cased in bug 307774. The changes introduced in bug 332588 no longer seem to work - dropping a link into the textbox input doesn't trigger the addhook, it just pastes the link.
Most of the paste functionality is now handled by the standard functionality of the textbox input but still need to deal the multi-line paste though this can be done more easily through an event listener.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9430581 - Flags: review?(frgrahl)
Attachment #9430581 - Flags: approval-comm-release?

Comment on attachment 9430581 [details] [diff] [review]
1924332-irc-input-paste-25320.patch

lgtm r/a+

Attachment #9430581 - Flags: review?(frgrahl)
Attachment #9430581 - Flags: review+
Attachment #9430581 - Flags: approval-comm-release?
Attachment #9430581 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/a799a75f2893
Use eventListerner instead of addhook nsICommandParams for chat window input paste. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/5dfb94ce38da9b65f155b68c2da51daed4210da4
Use eventListerner instead of addhook nsICommandParams for chat window input paste. r=frg a=frg

Whiteboard: SM2.53.20
Summary: Use eventListerner instead of addhook nsICommandParams for chat window input paste → Use eventListener instead of addhook nsICommandParams for chat window input paste
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: