Closed Bug 1924666 Opened 4 months ago Closed 3 months ago

Contextual Search should show configuration engines that arent enabled

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed
firefox135 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng-scotchbonnet])

Attachments

(1 file)

Bug 1924666 - Enable ContextualSearch to search engines from configuration.
48 bytes, text/x-phabricator-request
Details | Review

With Contextual Seach enabled visit https://www.ecosia.org/ and perform a search via the contextual search button, the resulting url should be identical to as if we had used the dedicated search button

Assignee: nobody → dharvey
Whiteboard: [sng-scotchbonnet]
Severity: -- → S2
Priority: -- → P1

Did some testing and some clarification needed, if the user visits the home page of an engine that is currently installed via their search configuration, then performing a search via the contextual search button will use that configuration (and codes etc).

However if the users visits an engine that we have built in to firefox but is not enabled via the search configuration and that engines home page has an open search definition available, then the feature will pick up that open search definition and use that instead.

It seems feasible for the feature to pick up all engines in our configuration, not only the enabled ones, I did have something very similiar planned in https://bugzilla.mozilla.org/show_bug.cgi?id=1891861, that was a larger and lower priority project but likely something we want to pick up sooner

Summary: Contextual Search uses opensearch over built in engine → Contextual Search should show configuration engines that arent enabled
Attachment #9432302 - Attachment description: WIP: Bug 1924666 - Enable ContextualSearch to search engines from configuration → Bug 1924666 - Enable ContextualSearch to search engines from configuration.
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be2c86185218 Enable ContextualSearch to search engines from configuration. r=daisuke,mcheang

Backed out for causing bc failures @ browser_move_tab_to_new_window.js

[task 2024-10-30T12:28:17.034Z] 12:28:17     INFO - Return that tab back to its original window and select it.
[task 2024-10-30T12:28:17.035Z] 12:28:17     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_move_tab_to_new_window.js | The value of the urlbar should have been moved. - "hello world" == "hello world" - 
[task 2024-10-30T12:28:17.035Z] 12:28:17     INFO - Buffered messages finished
[task 2024-10-30T12:28:17.038Z] 12:28:17     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_move_tab_to_new_window.js | A promise chain failed to handle a rejection: null has no properties - stack: queryActions@resource:///modules/ActionsProviderContextualSearch.sys.mjs:60:33
[task 2024-10-30T12:28:17.038Z] 12:28:17     INFO - async*startQuery@resource:///modules/UrlbarProviderGlobalActions.sys.mjs:67:44
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - tryMethod@resource:///modules/UrlbarUtils.sys.mjs:2506:30
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - startQuery@resource:///modules/UrlbarProvidersManager.sys.mjs:599:22
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - start/<@resource:///modules/UrlbarProvidersManager.sys.mjs:633:39
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - promise callback*start@resource:///modules/UrlbarProvidersManager.sys.mjs:632:34
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - async*startQuery@resource:///modules/UrlbarProvidersManager.sys.mjs:313:17
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - async*startQuery@resource:///modules/UrlbarController.sys.mjs:137:24
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - startQuery@resource:///modules/UrlbarInput.sys.mjs:1726:52
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - _on_input@resource:///modules/UrlbarInput.sys.mjs:4178:10
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - handleEvent@resource:///modules/UrlbarInput.sys.mjs:663:23
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - fireInputEvent@resource://testing-common/UrlbarTestUtils.sys.mjs:1202:28
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - moveTabIntoNewWindowAndBack@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_move_tab_to_new_window.js:24:19
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - async*move_loaded_page_with_value@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_move_tab_to_new_window.js:69:9
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-30T12:28:17.039Z] 12:28:17     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - Rejection date: Wed Oct 30 2024 12:28:16 GMT+0000 (Coordinated Universal Time) - false == true - 
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - Stack trace:
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - chrome://mochikit/content/browser-test.js:handleTask:1173
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-10-30T12:28:17.040Z] 12:28:17     INFO - Leaving test bound move_loaded_page_with_value
[task 2024-10-30T12:28:17.041Z] 12:28:17     INFO - Entering test bound move_tab_into_new_window_and_open_new_tab
[task 2024-10-30T12:28:17.042Z] 12:28:17     INFO - Open a new tab.
[task 2024-10-30T12:28:17.042Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fc73e13b400 == 4 [pid = 4465] [id = 150]
[task 2024-10-30T12:28:17.043Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 11 (7fc7400a8800) [pid = 4465] [serial = 405] [outer = 0]
[task 2024-10-30T12:28:17.044Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 12 (7fc73e140000) [pid = 4465] [serial = 406] [outer = 7fc7400a8800]
[task 2024-10-30T12:28:17.044Z] 12:28:17     INFO - GECKO(4254) | [WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2024-10-30T12:28:17.045Z] 12:28:17     INFO - GECKO(4254) | [WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2024-10-30T12:28:17.046Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: '!mCancelable', file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:418
[task 2024-10-30T12:28:17.046Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: WebProgress Ignored: BrowsingContext is null or discarded: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3165
[task 2024-10-30T12:28:17.047Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: WebProgress Ignored: BrowsingContext is null or discarded: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3165
[task 2024-10-30T12:28:17.047Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: WebProgress Ignored: BrowsingContext is null or discarded: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3165
[task 2024-10-30T12:28:17.048Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: WebProgress Ignored: BrowsingContext is null or discarded: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:3165
[task 2024-10-30T12:28:17.049Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (7fc73c5ee000) [pid = 4527] [serial = 160] [outer = 0] [url = about:newtab]
[task 2024-10-30T12:28:17.049Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (7fc73c5ea000) [pid = 4527] [serial = 168] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.050Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (7fc73c5e4c00) [pid = 4527] [serial = 170] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.051Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (7fc73c5e9000) [pid = 4527] [serial = 172] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.062Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7fc73db4c800) [pid = 4527] [serial = 183] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.063Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7fc73db4c400) [pid = 4527] [serial = 181] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.063Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7fc73db51000) [pid = 4527] [serial = 179] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.064Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7fc73c5ec000) [pid = 4527] [serial = 174] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.065Z] 12:28:17     INFO - GECKO(4254) | [Child 4527: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fc73c5ee400) [pid = 4527] [serial = 176] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.065Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 13 (7fc73e135800) [pid = 4465] [serial = 407] [outer = 7fc7400a8800]
[task 2024-10-30T12:28:17.066Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fc74127dc00 == 2 [pid = 10383] [id = 0] [url = https://www.example.com/]
[task 2024-10-30T12:28:17.067Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fc73fdb3000 == 1 [pid = 10383] [id = 2] [url = about:blank]
[task 2024-10-30T12:28:17.068Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fc741281800 == 0 [pid = 10383] [id = 1] [url = about:blank]
[task 2024-10-30T12:28:17.068Z] 12:28:17     INFO - GECKO(4254) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpdl938tvt.mozrunner/runtests_leaks_tab_pid10483.log
[task 2024-10-30T12:28:17.069Z] 12:28:17     INFO - GECKO(4254) | [Child 10483, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:757
[task 2024-10-30T12:28:17.070Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7fc73fdacc00) [pid = 10383] [serial = 7] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.070Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7fc741283800) [pid = 10383] [serial = 5] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.071Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7fc741277000) [pid = 10383] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.071Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7fc741284c00) [pid = 10383] [serial = 3] [outer = 0] [url = https://www.example.com/]
[task 2024-10-30T12:28:17.072Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fc740959000) [pid = 10383] [serial = 1] [outer = 0] [url = https://www.example.com/]
[task 2024-10-30T12:28:17.072Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7fc73fdef400) [pid = 10383] [serial = 6] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.073Z] 12:28:17     INFO - GECKO(4254) | [Child 10383: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7fc74095cc00) [pid = 10383] [serial = 4] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.073Z] 12:28:17     INFO - Move the new tab into a new window.
[task 2024-10-30T12:28:17.074Z] 12:28:17     INFO - GECKO(4254) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-10-30T12:28:17.074Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (7fc73e138800) [pid = 4465] [serial = 397] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.077Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (7fc73e141400) [pid = 4465] [serial = 394] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.078Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (7fc73e13e000) [pid = 4465] [serial = 396] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.079Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fc73e13b000 == 3 [pid = 4465] [id = 147] [url = about:blank]
[task 2024-10-30T12:28:17.080Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fc73e13f000 == 2 [pid = 4465] [id = 149] [url = about:blank]
[task 2024-10-30T12:28:17.081Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fc73e134800 == 1 [pid = 4465] [id = 148] [url = about:blank]
[task 2024-10-30T12:28:17.081Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f8f9376cc00 == 13 [pid = 4254] [id = 119]
[task 2024-10-30T12:28:17.082Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 29 (7f8f95608600) [pid = 4254] [serial = 274] [outer = 0]
[task 2024-10-30T12:28:17.082Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 30 (7f8f93777400) [pid = 4254] [serial = 275] [outer = 7f8f95608600]
[task 2024-10-30T12:28:17.083Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: NS_ENSURE_TRUE(uri) failed: file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1497
[task 2024-10-30T12:28:17.126Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (7fc7400ac600) [pid = 4465] [serial = 403] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.126Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (7fc7400aa600) [pid = 4465] [serial = 398] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.127Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (7fc7400abe00) [pid = 4465] [serial = 401] [outer = 0] [url = about:blank]
[task 2024-10-30T12:28:17.218Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: Please do not use mouseenter/leave events in chrome. They are slower than mouseover/out!: '!nsContentUtils::IsChromeDoc(window->GetExtantDoc())', file /builds/worker/checkouts/gecko/dom/events/EventListenerManager.cpp:462
[task 2024-10-30T12:28:17.256Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f8f9b6b6000 == 14 [pid = 4254] [id = 120]
[task 2024-10-30T12:28:17.257Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 31 (7f8f9c1aa400) [pid = 4254] [serial = 276] [outer = 0]
[task 2024-10-30T12:28:17.257Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 32 (7f8f9b7f5c00) [pid = 4254] [serial = 277] [outer = 7f8f9c1aa400]
[task 2024-10-30T12:28:17.317Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fc73e138800 == 2 [pid = 4465] [id = 151]
[task 2024-10-30T12:28:17.318Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (7fc7400a9000) [pid = 4465] [serial = 408] [outer = 0]
[task 2024-10-30T12:28:17.319Z] 12:28:17     INFO - GECKO(4254) | [Child 4465: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (7fc73e134000) [pid = 4465] [serial = 409] [outer = 7fc7400a9000]
[task 2024-10-30T12:28:17.320Z] 12:28:17     INFO - GECKO(4254) | [WARN  webrender::device::gl] Missing optimized shader source for gpu_cache_update
[task 2024-10-30T12:28:17.654Z] 12:28:17     INFO - GECKO(4254) | 1730291297653	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-10-30T12:28:17.691Z] 12:28:17     INFO - Type in the urlbar to open it and see an autofill suggestion.
[task 2024-10-30T12:28:17.697Z] 12:28:17     INFO - GECKO(4254) | [WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2024-10-30T12:28:17.698Z] 12:28:17     INFO - GECKO(4254) | [WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2024-10-30T12:28:17.704Z] 12:28:17     INFO - GECKO(4254) | [WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2024-10-30T12:28:17.725Z] 12:28:17     INFO - Waiting for the urlbar view to open
[task 2024-10-30T12:28:17.752Z] 12:28:17     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1673}]
[task 2024-10-30T12:28:17.753Z] 12:28:17     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1673}]
[task 2024-10-30T12:28:17.808Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp:1687
[task 2024-10-30T12:28:17.812Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7f8f9ccce800 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-30T12:28:17.813Z] 12:28:17     INFO - Urlbar view opened
[task 2024-10-30T12:28:17.902Z] 12:28:17     INFO - GECKO(4254) | [Parent 4254, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7f8f9ccce800 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-30T12:28:17.912Z] 12:28:17     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_move_tab_to_new_window.js | Heuristic result should be Autofill. -
Flags: needinfo?(dharvey)

Aplogies, some landed between my try run and landing that caused this to fail, latest try run is looking good to reland

Flags: needinfo?(dharvey)
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8bfb2c43cf5 Enable ContextualSearch to search engines from configuration. r=daisuke,mcheang

https://hg.mozilla.org/mozilla-central/rev/d8bfb2c43cf5

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

Verified as fixed during 135 Nightly feature run.

Status: RESOLVED → VERIFIED
status-firefox135: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: