1924747 - Firefox Suggest provides local PDFs from synced device as suggestion

Status: NEW

(Application Services :: Sync, defect, P2)

Description

[Nicholas Poon [:Nick]]

Attachment: Screenshot 2024-10-15 at 9.59.25 AM.png

STR

1. Connect 2 devices to the same mozilla account.
2. Download a PDF on device 2 and open it in firefox.
3. On device 1, type the name / directory of a downloaded file on a different device in the search bar
4. Notice that the local file on device 2 shows up in firefox suggest. Clicking on it results in a google search

Expected Behaviour

Local files from other devices do not show up on firefox suggest

Actual Behaviour

Local files from other devices show up on firefox suggest and clicking on it results in a search from the search engine

Comment 1

[Mark Banner (:standard8)]

Moving across to sync. The affected URL there starts with content:// is that something we should be excluding from sync?

Comment 2

[Lougenia Bailey]

I think this is more specific to the suggest component so moving once more. Please n/i me if I am mistaken and it belongs to sync.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

I think this is sync rather than suggest.

This is a bit messy - we exclude some schemes for synced tabs via the pref https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#3882. Sadly though, syncing of history does not use that, and instead appears to exclude only file:// urls (https://searchfox.org/mozilla-central/source/services/sync/modules/engines/history.sys.mjs#99). Then we'd need to do this for mobile. But we should fix this.