1924845 - Insert toolkit profile into selectable DB on upgrade

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Followup from bug 1883162. When the user creates their first selectable profile, we need to first add the existing toolkit profile to the selectable profile database, so that the user will be able to see their existing profile and their new profile in the various menus.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1924845 - Add the toolkit profile to the selectable profiles datastore on first creation. r?niklas!

Very WIP but works locally for the upgrade flow from toolkit to
selectable profiles, just getting feedback on whether it makes sense
from a user perspective.

---

Still need to debug activate handler behavior, temporarily disabled.

Also need to remove the try/catch around flush, that was from debugging.

Upgrade flow: add a first selectable profile and the menu shows your old
toolkit profile as "defualt profile".

the toolkit profile instance will show both profiles in a new window
(still need to update the code so the existing menuitem is updated if
profiles are added).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbf660df6cb6
Add the toolkit profile to the selectable profiles datastore on first creation. r=niklas

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cbf660df6cb6