1924977 - Missing edit menu entries when group header is selected in "grouped by sort" view

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Francesco (no longer active, use PM for contact)]

Attachment: edit-menu.png

STR:
Start TB into a folder which is unthreaded and sorted by date.
View > Sort By > Grouped by sort. Collapse all. Click on group header.
Use Edit menu, it has empty entries, see screenshot.

There are quite a few errors in the error console.

Tested in 132.0b4, but also reproducible in 115 and 128.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1924977 - Disable some thread-related commands for grouped views. r=#thunderbird-reviewers

• Disable cmd_selectThread for grouped views as this would lead to an invalid selection and is semantically incorrect anyway.
• Disable cmd_watchThread, cmd_killThread, and cmd_killSubthread for grouped views.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1924977 - Refactor hdrForFirstSelectedMessage and numSelected. r=#thunderbird-back-end-reviewers

• Use the same algorithm for single folder and search db views and remove nsMsgSearchDBView::GetHdrForFirstSelectedMessage().
• For expanded Grouped By Sort header rows, return null instead of the message header for the first message below.
• Do not count Grouped By Sort header rows in nsMsgDBView::GetNumSelected.
• Remove nsMsgDBView::GetKeyForFirstSelectedMessage() as this is now used only once and can be easily replaced.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c1fd627d14cc
Disable some thread-related commands for grouped views. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce7265270047
Refactor hdrForFirstSelectedMessage and numSelected. r=mkmelin