1924991 - [Toolbar redesign] The long press CFR is displayed again if it was not explicitly dismissed by user

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Delia Pop (Android QA)]

Attachment: CFR_Reappears.mp4

Steps to reproduce

1. Open Fenix with a clean profile.
2. Go to a website and tap on a few links inside the same tab.
3. Tap the back arrow button then tap the forward button on the navigation bar, in a span of 5 seconds.
4. Once the Long press CFR is displayed, change the orientation from Portrait to Landscape mode.
5. Once the Long press CFR disappears, change the orientation back to Portrait mode.
6. Repeat step 3: tap the back and/or forward arrow buttons in a span of 5 seconds.
7. Observe the result.

Expected behavior

Either of the following options:

• The CFR shouldn’t be dismissed automatically when changing the orientation so that the user could dismiss it explicitly.
• If the CFR is dismissed when changing the orientation, it should not be displayed again when the trigger conditions are met.

Actual behavior

The "Tap and hold the arrows to jump between pages in this tab's history" CFR is displayed every time the trigger conditions are met while in Portrait mode, if it was not explicitly dismissed by the user.

Additionally, the CFR:

• should point to the back button on the navigation bar (see issue 1910687 )
• should be displayed stuck to the navigation bar, as shown in Figma

Device information

• Firefox version: Nightly 133.0a1
• Android device model/Android OS version: any phone device

Any additional information?

The Long press CFR is triggered when within 5 seconds, the user does any of the following:

• Taps back button 2+ times.
• Taps forward button 2+ times.
• Taps back and forward 2+ times in any order.
  As per Figma requirements, the CFR is only shown once irrespective of which action caused the trigger.

The issue can also be reproduced if the app is closed while the CFR is displayed.

Comment 1

[Roger Yang [:royang]]

I've confirmed with Aarjav that this CFR should be shown only once. Even if the user didn't dismiss the CFR explicitly. I'll fix.
One thing to note is that since the user did not dismiss it explicitly, I will not record the dismiss event for the CFR.

Comment 2

[Roger Yang [:royang]]

Attachment: Bug 1924991 - Navigation buttons CFR should not be shown again even if the user didn't explicitly dismiss it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03e730a2e94e
Navigation buttons CFR should not be shown again even if the user didn't explicitly dismiss it. r=android-reviewers,petru

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/03e730a2e94e