1925285 - TypeError: setting getter-only property "_profileDir"2 SpotlightIntegration.sys.mjs:178:48

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Mac daily build. Started maybe 6 hours ago, I'm seeing a ton of ...

TypeError: setting getter-only property "_profileDir"2 SpotlightIntegration.sys.mjs:178:48
get _profileDir resource:///modules/SpotlightIntegration.sys.mjs:178
_getSearchPathForFolder resource:///modules/SpotlightIntegration.sys.mjs:196
_getSupportFile resource:///modules/SearchSupport.sys.mjs:810
msgsMoveCopyCompleted resource:///modules/SearchSupport.sys.mjs:674
cmd_deleteMessage chrome://messenger/content/mailCommon.js:298
doCommand chrome://messenger/content/mailCommon.js:737
<anonymous> chrome://messenger/content/about3Pane.js:6471
doCommand chrome://messenger/content/mailCommon.js:737
goDoCommand chrome://messenger/content/globalOverlay.js:99
oncommand chrome://messenger/content/messenger.xhtml:1

Unclear why it started. But I am also seeing a few of the following, which maybe started after opening the profiler in developer tools - I can't be sure....

ndexedDB UnknownErr: ActorsParent.cpp:577 5
05:32:31.487 services.settings: StorageError: Storage error: UnknownError: IndexedDB: thunderbird/search-config importChanges() IndexedDB: importChanges() in thunderbird/search-config The operation failed for reasons unrelated to the database itself and not covered by any other error code.
StorageError resource://services-settings/RemoteSettingsClient.sys.mjs:153
_adjustedError resource://services-settings/RemoteSettingsClient.sys.mjs:936
maybeSync resource://services-settings/RemoteSettingsClient.sys.mjs:824
Caused by: UnknownError: IndexedDB: thunderbird/search-config importChanges() IndexedDB: importChanges() in thunderbird/search-config The operation failed for reasons unrelated to the database itself and not covered by any other error code.
remote-settings.sys.mjs:394
05:32:31.497
StorageError: Storage error: UnknownError: IndexedDB: thunderbird/search-config importChanges() IndexedDB: importChanges() in thunderbird/search-config The operation failed for reasons unrelated to the database itself and not covered by any other error code.
StorageError resource://services-settings/RemoteSettingsClient.sys.mjs:153
_adjustedError resource://services-settings/RemoteSettingsClient.sys.mjs:936
maybeSync resource://services-settings/RemoteSettingsClient.sys.mjs:824
Caused by: UnknownError: IndexedDB: thunderbird/search-config importChanges() IndexedDB: importChanges() in thunderbird/search-config The operation failed for reasons unrelated to the database itself and not covered by any other error code.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1925285 - Fix "_profileDir" use if SpotlightIntegration.sys.mjs. r=freaktechnik,#thunderbird-reviewers

Comment 2

[Magnus Melin [:mkmelin]]

Let's continue the spotlight fixing in bug 1906928 (apparently this fix is not enough to get it fully going)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a42e31907dbd
Fix "_profileDir" use if SpotlightIntegration.sys.mjs. r=arschmitz

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9431796 [details]
Bug 1925285 - Fix "_profileDir" use if SpotlightIntegration.sys.mjs. r=freaktechnik,#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1888655
User impact if declined: Spotlight search broken. Not fully working with this patch either but it will be a pre-req to getting it working
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): no risk as it's completely broken as is

Comment 5

[Corey Bryant]

Comment on attachment 9431796 [details]
Bug 1925285 - Fix "_profileDir" use if SpotlightIntegration.sys.mjs. r=freaktechnik,#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 6

[Corey Bryant]

Thunderbird 128.5.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/3ee2cc260032