1925312 - Tabs not dragging properly between hidden tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[ssj2kite]

On Nightly 20241017095824, attempting to drag a tab (visible, newer, recently opened) to the left (past older, visible tabs), eventually the tab won't drag past tabs made after hidden tabs.

Reproduced on a clean build with the addon "Panorama Tab Groups" to hide tabs, made 5 new tabs, made a new tab group (not related to the new official feature) and made 5 more new tabs there. Switch back to the initial group (thus hiding the 5 newest tabs), and make another few new tabs. Then try dragging the newest tab back past the first 5 tabs created.

Regression points to bug #1923635.

Comment 1

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, thank you for the bug report!
Would it be possible for you to attach a screen recording of the issue or detail the reproduction steps?

Comment 2

[ssj2kite]

(In reply to Ardelean Oana, Desktop Test Engineering [:oardelean] from comment #1)

Would it be possible for you to attach a screen recording of the issue or detail the reproduction steps?

Gladly. Here is a link to a short demo of the problem, and here is a longer video showing the setup steps I took and showing the problem persisting in troubleshooting mode. All done on Windows 10, mozregression 6.2.2, Nightly build 20241017095824.
After playing around with it a bit more, I feel like my previous description of not being able to drag past just "older" tabs is inaccurate, and more so the problem is a combination of age and number of tabs hidden.

Comment 3

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you so much for the recordings and fast reply!
Managed to reproduce this issue ( with Panorama Tab Groups Add-on enabled) on Firefox Nightly 133.0a1.

Tested and reproduced on:

• macOS 14;
• Ubuntu 22;
• Windows 10;

Setting as NEW so the developing team can have a look.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Albert Scheiner [:alberts]]

See also ynunvvang's comment from bug 1928637#c2

Comment 7

[Alice0775 White]

I can reproduce the issue on Nightly134.0a1 Windows11.

STR

1. Open several number of tabs
2. Click on Firefox View Button at the left side of tab bar
3. Try dragging and dropping tabs to reorder them.

Comment 8

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2c637c9ac260f15c3b57d765fdd0e0c642b86739&tochange=539ec2225afbea690e887ef3e12befbfb797c8ca

Comment 9

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1925312 - Fix typo. r?#tabbrowser

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21bbacafe8fd
Fix typo. r=tabbrowser-reviewers,dwalker

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 9435068 [details]
Bug 1925312 - Fix typo. r?#tabbrowser

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: See comment 0, comment 7
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 7
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Typo fix
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/21bbacafe8fd

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9435068 [details]
Bug 1925312 - Fix typo. r?#tabbrowser

Approved for 133.0b5

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/93618b748434

Comment 16

[Negritas Sergiu, Desktop QA]

Hello I have managed to reproduce the issue with firefox 133.0b4 on Ubuntu 22.04. I can confirm that the issue is fixed with firefox 134.0a1(2024-11-05) on Ubuntu 22.04, Windows 10 and MacOS 15.

I will update the flag for 134 and leave the status and flag for 133 as it is until Beta 5 will be available .

Have a nice day!

Comment 17

[Negritas Sergiu, Desktop QA]

Hello I have verified the issue on Firefox 133.0b5 on Ubuntu 22.04, Windows 10 and MacOS 15 and I can confirm that the issue is fixed.

I will update the flags and the status of this issue.

Have a nice day!