1928637 - bug #1923635 cause tab drag broken if the first or last tab is hidden in 133 beta

Status: RESOLVED DUPLICATE of bug 1925312

(Firefox :: Tabbed Browser, defect)

Description

[ynunvvang]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

Have a hidden tab in tab bar e.g. fox view at the first or/and last position.
Drag a tab from the tab bar onto another position of the tab bar.

Actual results:

You can't drop a dragged tab on the tab bar from the tab bar.

Expected results:

You can drop the tab from the tab bar onto the tab bar.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[ynunvvang]

This is caused by https://hg.mozilla.org/mozilla-central/rev/539ec2225afb.

At https://hg.mozilla.org/mozilla-central/rev/539ec2225afb#l2.357 and https://hg.mozilla.org/mozilla-central/rev/539ec2225afb#l2.136 and other places the _getVisibleTabs() is replaced by visibleTabs
But at https://hg.mozilla.org/mozilla-central/rev/539ec2225afb#l2.376 it is replaced by allTabs then things go BOOM.

@Dão Gottwald your fault?