1925320 - Offer "unselect all" in the Export for Mobile configuration form

Status: NEW

(Thunderbird :: Account Manager, enhancement, P3)

Description

[Wayne Mery (:wsmwk)]

"unselect all" could be helpful for users with lots of accounts - like me, with 20

Comment 1

[Toby Pilling [:tobyp]]

Making it a checkbox would probably suffice

Comment 2

[Toby Pilling [:tobyp]]

Or disable the existing disablement, such that the button is always active and behaves like a toggle to allow the user to click again to deselect all if all are currently selected.

All accounts pre-selected by default
button enabled with label "DESELECT ALL"
Clicking "DESELECT ALL" button when all accounts are selected, de-selects everything and changes label to "SELECT ALL"
Clicking "SELECT ALL" button when no accounts are selected, selects everything and changes label to "DESELECT ALL"
Clicking "SELECT ALL" button when some accounts are selected, selects everything and changes label to "DESELECT ALL"
Individually checking all checkboxes changes button label to "DESELECT ALL"
If a user unchecks one check box or more, the button should change to "SELECT ALL"

Comment 3

[Magnus Melin [:mkmelin]]

Yeah, that sounds good. Perhaps Select All / Select None for wording.

Comment 4

[Martin Giger [:freaktechnik]]

It should actually use and follow the same pattern we've ended up building for the contact/calendar import selectors in account hub. Optimally we'd extract some of what we have there into a more generic custom element we can reuse here (and in other similar places)

Comment 5

[Magnus Melin [:mkmelin]]

Do you have a link to that?

Comment 6

[Martin Giger [:freaktechnik]]

Alexander worked to make that behave appropriately, so I think he should provide further guidance on how best to proceed.

Comment 7

[Alex Schmitz]

The work i did is here https://phabricator.services.mozilla.com/D267400 the basic idea is that the select all needs to be a tri state control (all, some, none) and represent this visually. The best way for us to do this is with a checkbox and allowing the indeterminate state, to keep it like a button we chose to place the checkbox within the label and style the label visually as a button.

Ideally we should extract this into its own component for reuse we have other existing places this needs to go as well. I don't mind doing this as well.