1925369 - Remove `operating_systems` support from Histograms, Scalars

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

A necessary task in migrating Scalar and Histogram APIs to Glean APIs is figuring out what to do with the operating_systems property. On platforms not matching the values supplied to that property, the probe constants don't exist, and so any Glean metric (which exists in all platforms) that mirrors to it will fail the compile on those platforms.

Rather than continuing to do this piecemeal as we did with Events, let's sunset operating_systems here as its own separate task.

Comment 1

[Florian Quèze [:florian]]

There are already multiple patches in bug 1923028 that remove some operating_systems fields.

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1925369 - Remove 'operating_systems' properties from Histogram definitions r?florian,janerik

All of the histograms were in code that only ran on the specified platform(s),
so the only thing that 'operating_systems' was doing was saving a few bytes
(the HistogramInfo, its part of gHistogramBucketLowerBoundIndex, its entry in
the PHF) and a few ms during build (less code in the headers,
fewer static asserts).

(( It didn't even save the bytes of storing the name in the string table. ))

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1925369 - Remove support for and documentation of 'operating_systems' fields for Events, Histograms, and Scalars r?TravisLong

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/581d74ca4495
Remove 'operating_systems' properties from Histogram definitions r=florian
https://hg.mozilla.org/integration/autoland/rev/019c11c5aa37
Remove support for and documentation of 'operating_systems' fields for Events, Histograms, and Scalars r=TravisLong

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/581d74ca4495
https://hg.mozilla.org/mozilla-central/rev/019c11c5aa37