1923028 - Migrate scalars to glean - part 1 landed in Firefox 133

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Let's figure out how to automatically migrate scalars to Glean.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for a11.*, r=chutten.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for findbar.*, r=chutten.

Depends on D225366

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.startup.*, r=chutten.

Depends on D225367

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for datasanitization.*, r=chutten.

Depends on D225368

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs in browser/components/places/, r=chutten.

Depends on D225369

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for gfx, r=chutten.

Depends on D225370

Comment 7

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for downloads.*, r=chutten.

Depends on D225371

Comment 8

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for preferences.prefs_file_was_invalid, r=chutten.

Depends on D225372

Comment 9

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for printing.*, r=chutten.

Depends on D225373

Comment 10

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for update.*, r=chutten.

Depends on D225649

Comment 11

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.searchinit.*, r=chutten.

Depends on D225650

Comment 12

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for migration.*, r=chutten.

Depends on D225651

Comment 13

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for pwmgr.potentially_breached_passwords, r=chutten.

Depends on D225652

Comment 14

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for contentblocking.*, r=chutten.

Depends on D225653

Comment 15

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for networking.doh_heuristic*, r=chutten.

Depends on D225666

Comment 16

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for telemetry.data_upload_optin, r=chutten.

Comment 17

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for policies.*, r=chutten.

Depends on D225810

Comment 18

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for pictureinpicture.*, r=chutten.

Depends on D225811

Comment 19

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for media.*, r=chutten.

Comment 20

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for webrtc.video.*, r=chutten.

Depends on D225817

Comment 21

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for widget.*, r=chutten.

Depends on D225860

Comment 22

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for startup.*, r=chutten.

Depends on D225861

Comment 23

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs in netwerk/protocol/http/, r=chutten.

Depends on D225862

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ba57548caa5
Migrate scalars to use Glean APIs for a11.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/55965be4702f
Migrate scalars to use Glean APIs for findbar.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/a0f7c3cb2e73
Migrate scalars to use Glean APIs for browser.startup.*, r=chutten,firefox-desktop-core-reviewers ,mconley.
https://hg.mozilla.org/integration/autoland/rev/2f30881ea9e1
Migrate scalars to use Glean APIs for datasanitization.*, r=chutten,firefox-desktop-core-reviewers ,mossop.
https://hg.mozilla.org/integration/autoland/rev/c9373cbe71af
Migrate scalars to use Glean APIs in browser/components/places/, r=chutten,sidebar-reviewers,fxview-reviewers,Standard8,jsudiaman.
https://hg.mozilla.org/integration/autoland/rev/647538b1e8d5
Migrate scalars to use Glean APIs for gfx, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/42af89449601
Migrate scalars to use Glean APIs for downloads.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/a6e0d152014d
Migrate scalars to use Glean APIs for preferences.prefs_file_was_invalid, r=chutten.

Comment 25

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0ba57548caa5
https://hg.mozilla.org/mozilla-central/rev/55965be4702f
https://hg.mozilla.org/mozilla-central/rev/a0f7c3cb2e73
https://hg.mozilla.org/mozilla-central/rev/2f30881ea9e1
https://hg.mozilla.org/mozilla-central/rev/c9373cbe71af
https://hg.mozilla.org/mozilla-central/rev/647538b1e8d5
https://hg.mozilla.org/mozilla-central/rev/42af89449601
https://hg.mozilla.org/mozilla-central/rev/a6e0d152014d

Comment 26

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs in security/manager/ssl/, r=chutten.

Comment 27

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs in toolkit/components/places/, r=chutten.

Depends on D225979

Comment 28

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for os.environment.*, r=chutten.

Depends on D225980

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1253c6772f62
Migrate scalars to use Glean APIs for pwmgr.potentially_breached_passwords, r=chutten,credential-management-reviewers,dimi.
https://hg.mozilla.org/integration/autoland/rev/e77b9a7d98e9
Migrate scalars to use Glean APIs for contentblocking.*, r=chutten,anti-tracking-reviewers,firefox-desktop-core-reviewers ,pbz.
https://hg.mozilla.org/integration/autoland/rev/b1a02fadef65
Migrate scalars to use Glean APIs for networking.doh_heuristic*, r=chutten.

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aa656cca8e7
Migrate scalars to use Glean APIs for media.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/052f964b38e9
Migrate scalars to use Glean APIs for webrtc.video.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/4b38f7dd65a4
Migrate scalars to use Glean APIs for widget.*, r=chutten,win-reviewers,gstoll.
https://hg.mozilla.org/integration/autoland/rev/eacb5ce75e05
Migrate scalars to use Glean APIs in netwerk/protocol/http/, r=chutten,necko-reviewers.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cfa735a41dd
Migrate scalars to use Glean APIs for printing.*, r=chutten.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf950f377181
Migrate scalars to use Glean APIs for update.*, r=chutten,application-update-reviewers,nalexander.
https://hg.mozilla.org/integration/autoland/rev/c9492894e175
Migrate scalars to use Glean APIs for migration.*, r=chutten,mconley.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55a67b2ba00
Migrate scalars to use Glean APIs for telemetry.data_upload_optin, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/d456c1262af2
Migrate scalars to use Glean APIs for policies.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/3cffdc7f51f4
Migrate scalars to use Glean APIs for pictureinpicture.*, r=chutten,mconley.

Comment 34

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1253c6772f62
https://hg.mozilla.org/mozilla-central/rev/e77b9a7d98e9
https://hg.mozilla.org/mozilla-central/rev/b1a02fadef65
https://hg.mozilla.org/mozilla-central/rev/9aa656cca8e7
https://hg.mozilla.org/mozilla-central/rev/052f964b38e9
https://hg.mozilla.org/mozilla-central/rev/4b38f7dd65a4
https://hg.mozilla.org/mozilla-central/rev/eacb5ce75e05
https://hg.mozilla.org/mozilla-central/rev/0cfa735a41dd

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0de824b926d6
Migrate scalars to use Glean APIs for startup.*, r=chutten,mossop.
https://hg.mozilla.org/integration/autoland/rev/6db21856f4de
Migrate scalars to use Glean APIs in security/manager/ssl/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/b6774d5247f5
Migrate scalars to use Glean APIs in toolkit/components/places/, r=chutten,places-reviewers,Standard8.
https://hg.mozilla.org/integration/autoland/rev/6f41dbd872e2
Migrate scalars to use Glean APIs for os.environment.*, r=chutten,mconley.

Comment 36

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_glean_metrics_exist.js

Backout link

Push with failures

Failure log

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be2a455534db
Migrate scalars to use Glean APIs for startup.*, r=chutten,mossop.
https://hg.mozilla.org/integration/autoland/rev/a8a819e4db3c
Migrate scalars to use Glean APIs in security/manager/ssl/, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/7b0d7bd0cae8
Migrate scalars to use Glean APIs in toolkit/components/places/, r=chutten,places-reviewers,Standard8.
https://hg.mozilla.org/integration/autoland/rev/dc75e788054f
Migrate scalars to use Glean APIs for os.environment.*, r=chutten,mconley.

Comment 38

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/be2a455534db
https://hg.mozilla.org/mozilla-central/rev/a8a819e4db3c
https://hg.mozilla.org/mozilla-central/rev/7b0d7bd0cae8
https://hg.mozilla.org/mozilla-central/rev/dc75e788054f

Comment 39

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars using scalarSetMaximum to Glean APIs in BrowserUsageTelemetry.sys.mjs, r=chutten.

Comment 40

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Remove constants used for scalar names in BrowserUsageTelemetry.sys.mjs, r=chutten.

Depends on D226368

Comment 41

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Use GIFFT mirroring for scalars that are already in both Glean and legacy telemetry, r=chutten.

Depends on D226369

Comment 42

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.engagement.* (excluding browser.engagement.navigation.*), r=chutten.

Depends on D226370

Comment 43

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.engagement.navigation.*, r=chutten.

Depends on D226371

Comment 44

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.search.{content,withads,adclicks}.*, r=chutten.

Depends on D226372

Comment 45

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.searchmode.*, r=chutten.

Depends on D226509

Comment 46

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.picked.*, r=chutten.

Depends on D226510

Comment 47

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.impression.*, r=chutten.

Depends on D226511

Comment 48

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.*, r=chutten.

Depends on D226512

Comment 49

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.ui.interaction.* probes outside of BrowserUsageTelemetry.sys.mjs, r=chutten.

Depends on D226513

Comment 50

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.ui.interaction.* probes in BrowserUsageTelemetry.sys.mjs, r=chutten.

Depends on D226514

Comment 51

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cf950f377181
https://hg.mozilla.org/mozilla-central/rev/c9492894e175
https://hg.mozilla.org/mozilla-central/rev/c55a67b2ba00
https://hg.mozilla.org/mozilla-central/rev/d456c1262af2
https://hg.mozilla.org/mozilla-central/rev/3cffdc7f51f4

Comment 52

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for browser.ui.toolbar_widgets and browser.ui.customized_widgets, r=chutten.

Depends on D226515

Comment 53

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for security.* in browser/components/BrowserGlue.sys.mjs, r=chutten.

Depends on D226686

Comment 54

[Florian Quèze [:florian]]

Attachment: Bug 1923028 - Migrate scalars to use Glean APIs for dom.*, r=chutten.

Depends on D226687

Comment 55

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864615d5913c
Use GIFFT mirroring for scalars that are already in both Glean and legacy telemetry, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/b1a5c0832ff1
Migrate scalars to use Glean APIs for browser.engagement.navigation.*, r=chutten,search-reviewers,scunnane.
https://hg.mozilla.org/integration/autoland/rev/4f1162439275
Migrate scalars to use Glean APIs for browser.search.{content,withads,adclicks}.*, r=chutten,search-reviewers,scunnane.
https://hg.mozilla.org/integration/autoland/rev/b0f356b3bd41
Migrate scalars to use Glean APIs for urlbar.searchmode.*, r=chutten,search-reviewers,scunnane.
https://hg.mozilla.org/integration/autoland/rev/e35a5afd6934
Migrate scalars to use Glean APIs for browser.ui.interaction.* probes outside of BrowserUsageTelemetry.sys.mjs, r=chutten,mconley.
https://hg.mozilla.org/integration/autoland/rev/1791847b7b9f
Migrate scalars to use Glean APIs for browser.ui.interaction.* probes in BrowserUsageTelemetry.sys.mjs, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/327937a640c5
Migrate scalars to use Glean APIs for dom.*, r=chutten.

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15c9348eedb9
Migrate scalars to use Glean APIs for security.* in browser/components/BrowserGlue.sys.mjs, r=chutten,firefox-desktop-core-reviewers .

Comment 57

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/864615d5913c
https://hg.mozilla.org/mozilla-central/rev/b1a5c0832ff1
https://hg.mozilla.org/mozilla-central/rev/4f1162439275
https://hg.mozilla.org/mozilla-central/rev/b0f356b3bd41
https://hg.mozilla.org/mozilla-central/rev/e35a5afd6934
https://hg.mozilla.org/mozilla-central/rev/1791847b7b9f
https://hg.mozilla.org/mozilla-central/rev/327937a640c5

Comment 58

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810a76d6befb
Migrate scalars to use Glean APIs for browser.ui.toolbar_widgets and browser.ui.customized_widgets, r=chutten.

Comment 59

[Florian Quèze [:florian]]

I will move the remaining patches to a new bug so this bug can be closed within the 133 target milestone.

Comment 60

[Phabricator Automation]

Comment on attachment 9432316 [details]
Bug 1923028 - Migrate scalars using scalarSetMaximum to Glean APIs in BrowserUsageTelemetry.sys.mjs, r=chutten.

Revision D226368 was moved to bug 1927093. Setting attachment 9432316 [details] to obsolete.

Comment 61

[Phabricator Automation]

Comment on attachment 9432317 [details]
Bug 1923028 - Remove constants used for scalar names in BrowserUsageTelemetry.sys.mjs, r=chutten.

Revision D226369 was moved to bug 1927093. Setting attachment 9432317 [details] to obsolete.

Comment 62

[Phabricator Automation]

Comment on attachment 9432575 [details]
Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.picked.*, r=chutten.

Revision D226511 was moved to bug 1927093. Setting attachment 9432575 [details] to obsolete.

Comment 63

[Phabricator Automation]

Comment on attachment 9432576 [details]
Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.impression.*, r=chutten.

Revision D226512 was moved to bug 1927093. Setting attachment 9432576 [details] to obsolete.

Comment 64

[Phabricator Automation]

Comment on attachment 9432577 [details]
Bug 1923028 - Migrate scalars to use Glean APIs for urlbar.*, r=chutten.

Revision D226513 was moved to bug 1927093. Setting attachment 9432577 [details] to obsolete.

Comment 65

[Phabricator Automation]

Comment on attachment 9432319 [details]
Bug 1923028 - Migrate scalars to use Glean APIs for browser.engagement.* (excluding browser.engagement.navigation.*), r=chutten.

Revision D226371 was moved to bug 1927093. Setting attachment 9432319 [details] to obsolete.

Comment 66

[Phabricator Automation]

Comment on attachment 9431027 [details]
Bug 1923028 - Migrate scalars to use Glean APIs for browser.searchinit.*, r=chutten.

Revision D225651 was moved to bug 1927093. Setting attachment 9431027 [details] to obsolete.

Comment 67

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/15c9348eedb9

Comment 68

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/810a76d6befb