Track down the extra 3px necessary to avoid popover urlbar flickering in perf tests
Categories
(Firefox :: Address Bar, task, P3)
Tracking
()
People
(Reporter: sfoster, Unassigned)
References
Details
While testing the patch in Bug 1921811, the browser/base/content/test/performance/browser_urlbar_keyed_search.js test was failing, reporting unexpected flickering. These tests run with the browser.urlbar.disableExtendForTests pref set, which results in the breakout-extend-disabled instead of the breakout-expanded being set on the #urlbar element.
Something about this distinction resulted in a 3-4px vertical offset, detectable only in this configuration. It would be good to track it down properly.
|
||
Updated•12 days ago
|
|
Reporter | |
Comment 1•12 days ago
|
||
After another backout and further discussion, I filed bug 1926118 to revisit and re-enable the urlbar perf tests so they don't rely on this test-only pref and codepath to pass. That should remove the need for this browser.urlbar.disableExtendForTests margin-top workaround entirely. I'll make it a dupe so we ensure the symptoms here do get addressed.
Description
•