1926118 - Reenable the browser_urlbar_keyed_search.js and browser_urlbar_search.js perf tests

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Sam Foster [:sfoster] (he/him)]

There are 2 urlbar perf tests browser/base/content/test/performance/browser_urlbar_keyed_search.js and browser/base/content/test/performance/browser_urlbar_search.js which ostensibly check for unwanted reflows but rely on a test-only configuration to pass. The browser.urlbar.disableExtendForTests pref is set for this test suite and results in a early-return in UrlbarInput's startLayoutExtend. It looks like this was originally added as a workaround in bug 1577541. With the patch in Bug 1921811 to make the urlbar a popover, the divergence between test and non-test code increases to the point where these perf tests aren't really providing any value and are just requiring maintenance of an additional test-only code path.

This unblocks 1921811, but we do want this coverage, so I'm suggesting a P1 to try and restore the tests asap.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1926118 - Fix the perf tests for the urlbar breakout. r?dao!

Comment 3

[Sam Foster [:sfoster] (he/him)]

A try push to run the urlbar performance tests with the disableExtendForTests pref and codepath removed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25f7c0a5243d
Fix the perf tests for the urlbar breakout. r=desktop-theme-reviewers,urlbar-reviewers,jteow,emilio

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/25f7c0a5243d