Closed
Bug 1925871
Opened 3 months ago
Closed 2 months ago
Remove use of NSGetModule in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file, 1 obsolete file)
|
7.43 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
As cZ is integrated, no longer need to have the backwards compatibility of NSGetModule, so let's remove it.
Whilst here make use of Services.jsm and XPCOMUtils.jsm
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9432114 -
Flags: review?(frgrahl)
Attachment #9432114 -
Flags: approval-comm-release?
Missed one removal
Attachment #9432114 -
Attachment is obsolete: true
Attachment #9432114 -
Flags: review?(frgrahl)
Attachment #9432114 -
Flags: approval-comm-release?
Attachment #9432115 -
Flags: review?(frgrahl)
Attachment #9432115 -
Flags: approval-comm-release?
|
||
Updated•2 months ago
|
|
|
||
Comment 3•2 months ago
|
||
Comment on attachment 9432115 [details] [diff] [review]
1925871-irc-remove-NSGetModule-v1_1-25320.patch
lgtm r/a*
Attachment #9432115 -
Flags: review?(frgrahl)
Attachment #9432115 -
Flags: review+
Attachment #9432115 -
Flags: approval-comm-release?
Attachment #9432115 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/755db438e419
Remove use of NSGetModule in cZ. r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•