Closed
Bug 1926406
Opened 3 months ago
Closed 2 months ago
Tidy up chatzilla-service.js
Categories
(SeaMonkey :: Chat, enhancement)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
17.31 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Merge protocol handler code into chatzilla-service.js and do some tidying up.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
There's potentially more code that can be tidied up, happy for feedback on that.
Attachment #9432655 -
Flags: review?(frgrahl)
Attachment #9432655 -
Flags: feedback?(tobin)
Attachment #9432655 -
Flags: approval-comm-release?
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9432655 [details] [diff] [review]
1926406-irc-chatzilla-service-25320.patch
lgtm r/a+
I didn't spot anything which can be cleaned up a bit more immediately. Will take another look if/when I find some time.
Attachment #9432655 -
Flags: review?(frgrahl)
Attachment #9432655 -
Flags: review+
Attachment #9432655 -
Flags: approval-comm-release?
Attachment #9432655 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e4618db70087
Tidy up chatzilla-service.js. r=frg f=tobin
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•