1926406 - Tidy up chatzilla-service.js

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

Merge protocol handler code into chatzilla-service.js and do some tidying up.

Comment 1

[Ian Neal]

Attachment: 1926406-irc-chatzilla-service-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

There's potentially more code that can be tidied up, happy for feedback on that.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9432655 [details] [diff] [review]
1926406-irc-chatzilla-service-25320.patch

lgtm r/a+

I didn't spot anything which can be cleaned up a bit more immediately. Will take another look if/when I find some time.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e4618db70087
Tidy up chatzilla-service.js. r=frg f=tobin

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/0128649c4b6a83d62e7481c069f1035f150c5339
Tidy up chatzilla-service.js. r=frg f=tobin a=frg

Comment 5

[Matt A. Tobin [:nsITobin]]

Comment on attachment 9432655 [details] [diff] [review]
1926406-irc-chatzilla-service-25320.patch

Review of attachment 9432655 [details] [diff] [review]:
-----------------------------------------------------------------

I thought I did this ages ago, sorry about that. Nothing stands out as far as I can tell that might become an issue down the line.