Closed Bug 1925971 Opened 2 years ago Closed 2 years ago

Port bug 1917575: ForkServer should run pthread_atfork

Categories

(Thunderbird :: Upstream Synchronization, defect)

Thunderbird 133
defect

Tracking

(Not tracked)

RESOLVED FIXED
133 Branch

People

(Reporter: babolivier, Assigned: babolivier)

References

Details

Attachments

(1 external file)

Bug 1917575 changed SandboxLaunch::Fork to include symbols that are only defined if MOZ_ENABLE_FORKSERVER is defined, which does not seem to be the case for Thunderbird by default on Linux (and Linux-like platforms) - but it is for Firefox. As a result, Linux builds of Thunderbird fail with:

 1:49.88 In file included from Unified_cpp_linux_launch0.cpp:11:
 1:49.89 /home/babolivier/Documents/mozilla/mozilla-central/security/sandbox/linux/launch/SandboxLaunch.cpp:628:3: error: use of undeclared identifier 'run_moz_pthread_atfork_handlers_prefork'
 1:49.89   628 |   run_moz_pthread_atfork_handlers_prefork();
 1:49.89       |   ^
 1:49.89 /home/babolivier/Documents/mozilla/mozilla-central/security/sandbox/linux/launch/SandboxLaunch.cpp:631:5: error: use of undeclared identifier 'run_moz_pthread_atfork_handlers_postfork_parent'
 1:49.90   631 |     run_moz_pthread_atfork_handlers_postfork_parent();
 1:49.90       |     ^
 1:49.90 /home/babolivier/Documents/mozilla/mozilla-central/security/sandbox/linux/launch/SandboxLaunch.cpp:635:3: error: use of undeclared identifier 'run_moz_pthread_atfork_handlers_postfork_child'
 1:49.91   635 |   run_moz_pthread_atfork_handlers_postfork_child();
 1:49.91       |   ^
 1:49.91 3 errors generated.
Assignee: nobody → brendan
Status: NEW → ASSIGNED
Pushed by brendan@thunderbird.net: https://hg.mozilla.org/integration/autoland/rev/36b54309304b Only call the interposer when the fork server is enabled. r=gerard-majax
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: