1926156 - pushing changes to the `moz-phab` repo doesn't cause the revision to close in Phabricator

Status: NEW

(Conduit :: Phabricator, defect, P3)

Description

[Connor Sheehan [:sheehan]]

For a while we have been manually closing Phabricator revisions after pushing them to the moz-phab repo. Phabricator itself is closing the revisions, and we can see in the Phabricator history view that the Phab revision can be detected for the commit.

:shtrom and I have been looking into this by digging through Phabricator internals. As a sanity check we should set up the moz-phab repo to more closely match how we set up m-c, with all URIs set to No I/O.

Comment 1

[Connor Sheehan [:sheehan]]

I updated the revision URIs to match the setup of m-c.

Comment 2

[Connor Sheehan [:sheehan]]

For now this is S3, since it has a "workaround" of manually closing the revisions. We should ensure this functionality isn't broken due to using Git instead of Mercurial, as it would need to be fixed before the Git migration.

Comment 3

[Olivier Mehani [:shtrom]]

FWIW, this revision https://phabricator.services.mozilla.com/D227791 was manually closed, but Phabricator later detected an associated commit, 5 minutes later (the code was committed/pushed around half an hour prior to that

shtrom closed this revision.Tue, Nov 5, 10:06
shtrom added a commit: rREVIEWa86211805692: dev: update requirements to HG 6.8.2 (Bug 1923371) r=sheehan.Tue, Nov 5, 10:11

Also, https://phabricator.services.mozilla.com/rREVIEWa862118056927d3f645cb81da2365725abf65842

shtrom committed rREVIEWa86211805692: dev: update requirements to HG 6.8.2 (Bug 1923371) r=sheehan (authored by shtrom).Tue, Nov 5, 09:37
shtrom added an edge: D227791: dev: update requirements to HG 6.8.2 (Bug 1923371) r?sheehan.

Comment 5

[Olivier Mehani [:shtrom]]

I have been able to reproduce this fairly reliably in suite.