1929942 - Uplift revisions are not closed automatically after landing

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect, P2)

Description

[Donal Meehan [:dmeehan]]

Relativity recently, within the last week, I've noticed that uplift revisions were not filtered from the Uplift Dashboard after they landed.

The revisions were not automatically closed after the patch landed.

Here are some examples:

• https://phabricator.services.mozilla.com/D227811
• https://phabricator.services.mozilla.com/D228306
• https://phabricator.services.mozilla.com/D227535
• https://phabricator.services.mozilla.com/D227283

This only affects revisions landed in release, esr128, and esr115.
Revisions landing in beta are closed automatically.

Comment 1

[Connor Sheehan [:sheehan]]

Bug 1926156 may also be related.

Comment 2

[Olivier Mehani [:shtrom]]

Looking at the repo status https://phabricator.services.mozilla.com/source/esr115/manage/basics/ , it looks like Phabricator hasn't refreshed its copy of the repo in the last week.

Updates OK	Last updated Sat, Nov 2, 09:15 (6 d, 1 h ago).
Fully Imported	
Prioritized	This repository will be updated soon!

Comment 3

[Connor Sheehan [:sheehan]]

Dave, could you check if the daemon is stuck while trying to load the history for esr115/esr128/release? shtrom and I tried looking but we couldn't find anything in the logs in GCP.

Comment 4

[David Lawrence [:dkl]]

Attachment: image.png

https://phabricator.services.mozilla.com/daemon/

Might have something to do with it. I will run it in task manually in the phabricator shell to see what the error is.

Comment 5

[David Lawrence [:dkl]]

~/phabricator/bin $ ./worker execute --id 94127329
 EXECUTE  Executing Task 94127329 (DiffusionUpdateObjectAfterCommitWorker)...
[2024-11-08 03:08:32] EXCEPTION: (RuntimeException) Undefined index: tree at [<arcanist>/src/error/PhutilErrorHandler.php:251]
arcanist(head=stable, ref.stable=09daac294d69), moz-extensions(), phabricator()
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/differential/editor/DifferentialTransactionEditor.php:1324]
  #1 DifferentialTransactionEditor::updateRevisionHashTable(DifferentialRevision, DifferentialDiff) called at [<phabricator>/src/applications/differential/editor/DifferentialTransactionEditor.php:388]
  #2 DifferentialTransactionEditor::applyFinalEffects(DifferentialRevision, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1412]
  #3 PhabricatorApplicationTransactionEditor::applyTransactions(DifferentialRevision, array) called at [<phabricator>/src/applications/differential/engine/DifferentialDiffExtractionEngine.php:365]
  #4 DifferentialDiffExtractionEngine::updateRevisionWithCommit(DifferentialRevision, PhabricatorRepositoryCommit, array, PhabricatorDaemonContentSource) called at [<phabricator>/src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php:208]
  #5 DiffusionUpdateObjectAfterCommitWorker::updateRevision(PhabricatorRepositoryCommit, DifferentialRevision) called at [<phabricator>/src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php:57]
  #6 DiffusionUpdateObjectAfterCommitWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:124]
  #7 PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:160]
  #8 PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php:97]
  #9 PhabricatorWorkerManagementExecuteWorkflow::execute(PhutilArgumentParser) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:492]
  #10 PhutilArgumentParser::parseWorkflowsFull(array) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:377]
  #11 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/setup/manage_worker.php:21]

Comment 6

[David Lawrence [:dkl]]

Also found this:

Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] [2024-11-01 22:34:56] EXCEPTION: (PhutilProxyException) Error while updating the "esr115" repository. {>} (CommandException) Command killed by timeout after running for more than 900 seconds.
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] COMMAND
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] /app/phabricator/bin/repository update  -- rESRONEONEFIVE
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] 
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] STDOUT
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] (empty)
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] 
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] STDERR
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] (empty) at [<arcanist>/src/future/exec/ExecFuture.php:436]
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000] arcanist(head=stable, ref.stable=09daac294d69), moz-extensions(), phabricator()
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000]   #0 <#3> ExecFuture::raiseResultError(array) called at [<arcanist>/src/future/exec/ExecFuture.php:340]
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000]   #1 <#3> ExecFuture::resolvex() called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:496]
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000]   #2 phlog(PhutilProxyException) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:503]
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000]   #3 PhabricatorRepositoryPullLocalDaemon::resolveUpdateFuture(PhabricatorRepository, ExecFuture, integer) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:270]
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000]   #4 PhabricatorRepositoryPullLocalDaemon::run() called at [<phabricator>/src/infrastructure/daemon/PhutilDaemon.php:219]
Daemon 1229051 STDE [Fri, 01 Nov 2024 22:34:56 +0000]   #5 PhutilDaemon::execute() called at [<phabricator>/scripts/daemon/exec/exec_daemon.php:131]

Comment 7

[David Lawrence [:dkl]]

the esr115 still says Prioritized This repository will be updated soon! which means it is something is wrong and it is hung. We could restart it and see what happens.

Comment 8

[Connor Sheehan [:sheehan]]

Looks like the repos are back up to date now. We should look into adding some monitoring for this in the future so we know when the import daemon is stalled.