1926270 - On Windows "mach puppeter-test" fails with "Error: Shard did not result in any test files"

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since the shard changes from bug 1912292 landed I'm no longer able to run Puppeteer tests on Windows. They fail because no tests can be found:

uffer *\",\"skip\":true},{\"testIdPattern\":\"[network.spec] network Request.isNavigationRequest *\",\"skip\":false},{\"testIdPattern\":\"[network.spec] network Page.setByp
assServiceWorker *\",\"skip\":true},{\"testIdPattern\":\"[network.spec] network Page.setBypassServiceWorker *\",\"skip\":true},{\"testIdPattern\":\"[launcher.spec] Launcher
 specs Puppeteer Puppeteer.launch *\",\"skip\":true},{\"testIdPattern\":\"[input.spec] input tests Page.waitForFileChooser *\",\"skip\":false},{\"testIdPattern\":\"[idle_ov
erride.spec] *\",\"skip\":true},{\"testIdPattern\":\"[extensions.spec] *\",\"skip\":true},{\"testIdPattern\":\"[drag-and-drop.spec] Legacy Drag n' Drop *\",\"skip\":true},{
\"testIdPattern\":\"[drag-and-drop.spec] *\",\"skip\":false},{\"testIdPattern\":\"[devtools.spec] *\",\"skip\":true},{\"testIdPattern\":\"[device-request-prompt.spec] *\",\
"skip\":true},{\"testIdPattern\":\"[bfcache.spec] *\",\"skip\":true},{\"testIdPattern\":\"[autofill.spec] *\",\"skip\":false}]"
 0:35.43 pid:1584 }
 0:35.43 pid:1584
 0:35.43 pid:1584 Running ["firefox","headful","webDriverBiDi"] C:\mozilla-build\msys2\tmp\puppeteer-test-runner-0zc2C6\output.json
 0:35.47 pid:1584 Error: Shard did not result in any test files
 0:35.47 pid:1584     at main (C:\mozilla\mozilla-unified\remote\test\puppeteer\tools\mocha-runner\bin\mocha-runner.js:165:27)
 0:35.47 pid:1584     at Object.<anonymous> (C:\mozilla\mozilla-unified\remote\test\puppeteer\tools\mocha-runner\bin\mocha-runner.js:247:1)
 0:35.47 pid:1584     at Module._compile (node:internal/modules/cjs/loader:1356:14)
 0:35.47 pid:1584     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
 0:35.47 pid:1584     at Module.load (node:internal/modules/cjs/loader:1197:32)
 0:35.47 pid:1584     at Module._load (node:internal/modules/cjs/loader:1013:12)
 0:35.47 pid:1584     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
 0:35.47 pid:1584     at node:internal/main/run_main_module:28:49

The usage of shard works fine upstream in the Puppeteer repository also with the same version as we have vendored in mozilla-central.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1926270 - [puppeteer] Fix setting of shard values for mach commands.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d12ed0adaed0
[puppeteer] Fix setting of shard values for mach commands. r=webdriver-reviewers,Sasha

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d12ed0adaed0