1926483 - Make `WSRunScanner` free from editing host

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, WSRunScanner needs to take an editing host as a required parameter and it may stop scanning if it reaches non-editable content. However, the user needs to scan outside the editing host. For example, when we need to check whether we need to put a <br> at end of inline editing host, we need to check whether the inline editing host is immediately before a block boundary.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1926483 - part 1: Make `WSRunScanner` instance free from editing host r=m_kato!

If it scans starting from a editable point, it does not require the editing
host as an ancestor limiter. Therefore, some users can be free from editing
host.

Depends on D232937

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1926483 - part 2: Make `WSRunScanner::Get(InclusiveNext|Previous)CharPoint` free from editing host r=m_kato!

Depends on D233791

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1926483 - part 3: Make various `WSRunScanner` static methods take `WSRunScanner::Scan` and ancestor limiter r=m_kato!

Depends on D233792

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1926483 - part 4: Make `WSRunScanner::Scan(InclusiveNext|Previous)VisibleNodeOrBlockBoundary` take `WSRunScanner::Scan` and ancestor limiter r=m_kato!

Note that this removes a lot of aEditingHost params. This may cause odd
behavior if editing host is changed by a legacy mutation event listener.
However, it'll be completely deleted soon and even if we meet some regressions,
we can just restore the param to set aAncestorLimiter.

Depends on D233793

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1926483 - part 5: Fix some assertion failures which assume `WSRunScanner` works only with editable nodes r=m_kato!

Depends on D233794

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41b040b374a2
part 1: Make `WSRunScanner` instance free from editing host r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7aceecb585e4
part 2: Make `WSRunScanner::Get(InclusiveNext|Previous)CharPoint` free from editing host r=m_kato
https://hg.mozilla.org/integration/autoland/rev/1df51ca968f8
part 3: Make various `WSRunScanner` static methods take `WSRunScanner::Scan` and ancestor limiter r=m_kato
https://hg.mozilla.org/integration/autoland/rev/24bdcd7af3e0
part 4: Make `WSRunScanner::Scan(InclusiveNext|Previous)VisibleNodeOrBlockBoundary` take `WSRunScanner::Scan` and ancestor limiter r=m_kato
https://hg.mozilla.org/integration/autoland/rev/fa4c36cef1c5
part 5: Fix some assertion failures which assume `WSRunScanner` works only with editable nodes r=m_kato

Comment 7

[Atila Butkovits]

Backed out for causing failures at WSRunScanner.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3cd79f535be41e087388c50fbd8641a44607ac6c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fa4c36cef1c5f465dccff5d7cd36b2edb0100191&selectedTaskRun=L4kl8DrjTVa2d285-ls-ow.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=491387048&repo=autoland&lineNumber=27186

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fcf1ac4f4f5
part 1: Make `WSRunScanner` instance free from editing host r=m_kato
https://hg.mozilla.org/integration/autoland/rev/07221ff52d54
part 2: Make `WSRunScanner::Get(InclusiveNext|Previous)CharPoint` free from editing host r=m_kato
https://hg.mozilla.org/integration/autoland/rev/21d25ec4ae50
part 3: Make various `WSRunScanner` static methods take `WSRunScanner::Scan` and ancestor limiter r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c28a76805cb6
part 4: Make `WSRunScanner::Scan(InclusiveNext|Previous)VisibleNodeOrBlockBoundary` take `WSRunScanner::Scan` and ancestor limiter r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ed2f02b40979
part 5: Fix some assertion failures which assume `WSRunScanner` works only with editable nodes r=m_kato

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4fcf1ac4f4f5
https://hg.mozilla.org/mozilla-central/rev/07221ff52d54
https://hg.mozilla.org/mozilla-central/rev/21d25ec4ae50
https://hg.mozilla.org/mozilla-central/rev/c28a76805cb6
https://hg.mozilla.org/mozilla-central/rev/ed2f02b40979