1926486 - Empty editor when opening the Debugger on a page where I opened a source in a previous session

Status: RESOLVED DUPLICATE of bug 1873657

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the debugger, make sure to close all editor tabs you might have and clear all the breakpoints
3. Open console-test-animation.js
4. Close the toolbox
5. Re-open the debugger

Expected results

The console-test-animation.js file is open and the source is visible

Actual results

The console-test-animation.js file is open but the source is not visible. The editor is empty and the gutter only has one line

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1926486 - [devtools] Load the source content on editor component mount r=#devtools

Load the source content on componentDidMount, to make sure the selected source gets displayed.
In the majority of the scenarios a UNSAFE_componentWillReceiveProps will fire after the initial mount, but in a few cases
(mostly after a close and reopening of the toolbox) it does not fire.

Strugling to reproduce the failing scenarios with a test.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Fixed in Bug 1873657.

The issue was that sometimes we get the selected source content information before the editor is ready, but never updated the source content after the editor was finally received.