1927073 - "RootTransport._sendCommandToBrowsingContext" fails when browsing context was replaced

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When trying to write a test for bug 1921314 I noticed that RootTransport._sendCommandToBrowsingContext() currently fails when the specified browsing context was replaced by a navigation. This happens because we never update the browsing context within a root module method and will continue using it when forwarding a command to the window global. Specifically root module commands are affected that internally call certain methods from the window global module with a delay.

As result we currently fail here with a webProgress that is null:

   let attempts = 0;
    while (true) {
      try {
        if (!webProgress.browsingContext.currentWindowGlobal) {
          await lazy.waitForCurrentWindowGlobal(webProgress.browsingContext);
        }

In case of retries are allowed for the actual command we should try to retrieve the new top-level browsing context for the associated browser element and use its webProgress instead.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1927073 - [remote] Retrieve new browsing context if old one was replaced when forwarding a command to the window global.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9461994ee82
[remote] Retrieve new browsing context if old one was replaced when forwarding a command to the window global. r=webdriver-reviewers,jdescottes

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d9461994ee82