1930530 - Marionette doesn't retry to dispatch actions when the JSWindowActor gets replaced

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I've fixed a similar case already for the Remote Agent (bug 1927073) but we actually missed that Marionette is affected as well. So whenever an action chain is performed and a cross-origin navigation is happening, the top-level browsing context is replaced and we need to find the proper one again for retrying.

Further in Marionette we do not yet automatically retry when an AbortError is happening when dispatching an action chain. So we should fix both together.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1930530 - [wdspec] Tests for "Perform Actions" to check that dispatching actions finishes even with an active navigation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1930530 - [marionette] Correctly retry to dispatch actions when the browsing context is replaced.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/791d6d12f922
[wdspec] Tests for "Perform Actions" to check that dispatching actions finishes even with an active navigation. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/9b98319f8d18
[marionette] Correctly retry to dispatch actions when the browsing context is replaced. r=webdriver-reviewers,jdescottes

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49179 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/791d6d12f922
https://hg.mozilla.org/mozilla-central/rev/9b98319f8d18

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot