1927214 - moz-page-nav should support an optional search box

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement, P3)

Description

[Mark Striemer [:mstriemer]]

With the settings redesign work the page nav has been redesigned to have the page's search input within the sidebar. This should be used for about:addons and about:preferences, but since Firefox View's search is to filter a specific page it should not be used there

Figma

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1927214 - Part 2: add support for subheading slot to moz-page-nav r=#recomp-reviewers

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1927214 - Part 3: refactor header to heading, fix test_moz_page_nav spacing r=#recomp-reviewers

Comment 3

[Hanna Jones [:hjones]]

Attachment: Bug 1927214 - Part 1: add support for aria-label to moz-input-search r=#recomp-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/181a5534f909
Part 1: add support for aria-label to moz-input-search r=tgiles
https://hg.mozilla.org/integration/autoland/rev/bd0405562d20
Part 2: add support for subheading slot to moz-page-nav r=reusable-components-reviewers,tgiles
https://hg.mozilla.org/integration/autoland/rev/015ee1aceffe
Part 3: refactor header to heading, fix test_moz_page_nav spacing r=reusable-components-reviewers,tgiles

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_experimental_features_resetall.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/122ad25187f4e1d93f562df5c8fb62b2c0cc0668

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js

TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | modified state C - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - Buffered messages finished
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js | modified state D - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - Stack trace:
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:test_ok:1599
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochitests/content/browser/browser/components/preferences/tests/browser_experimental_features_resetall.js:testResetAll:102
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | browser.ui.interaction.preferences_paneExperimental must be recorded. - true == true - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | browser.ui.interaction.preferences_paneExperimental must contain the 'test-featureC' key. - true == true - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | browser.ui.interaction.preferences_paneExperimental['test-featureC'] must contain the expected value - 1 == 1 - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | browser.ui.interaction.preferences_paneExperimental must be recorded. - true == true - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | browser.ui.interaction.preferences_paneExperimental must contain the 'test-featureD' key. - true == true - 
[task 2025-02-03T20:53:48.203Z] 20:53:48     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-02-03T20:53:48.204Z] 20:53:48     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js | browser.ui.interaction.preferences_paneExperimental['test-featureD'] must contain the expected value - 2 == 1 - 
[task 2025-02-03T20:53:48.204Z] 20:53:48     INFO - Stack trace:
[task 2025-02-03T20:53:48.204Z] 20:53:48     INFO - resource://testing-common/TelemetryTestUtils.sys.mjs:assertKeyedScalar:47
[task 2025-02-03T20:53:48.204Z] 20:53:48     INFO - chrome://mochitests/content/browser/browser/components/preferences/tests/browser_experimental_features_resetall.js:testResetAll:115
[task 2025-02-03T20:53:48.204Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-02-03T20:53:48.205Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-02-03T20:53:48.205Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-02-03T20:53:48.205Z] 20:53:48     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-02-03T20:53:48.205Z] 20:53:48     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-02-03T20:54:32.465Z] 20:54:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-02-03T20:54:32.465Z] 20:54:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js | Test timed out - 
[task 2025-02-03T20:54:32.468Z] 20:54:32     INFO - GECKO(9237) | Completed ShutdownLeaks collections in process 9237
[task 2025-02-03T20:54:32.469Z] 20:54:32     INFO - TEST-START | Shutdown
[task 2025-02-03T20:54:32.470Z] 20:54:32     INFO - Browser Chrome Test Summary
[task 2025-02-03T20:54:32.471Z] 20:54:32     INFO - Passed:  2381
[task 2025-02-03T20:54:32.471Z] 20:54:32     INFO - Failed:  3
[task 2025-02-03T20:54:32.472Z] 20:54:32     INFO - Todo:    0
[task 2025-02-03T20:54:32.472Z] 20:54:32     INFO - Mode:    e10s
[task 2025-02-03T20:54:32.473Z] 20:54:32     INFO - *** End BrowserChrome Test Results ***
[task 2025-02-03T20:54:32.496Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.497Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.498Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.498Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.498Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.498Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.498Z] 20:54:32     INFO - GECKO(9237) | Exiting due to channel error.
[task 2025-02-03T20:54:32.507Z] 20:54:32     INFO - TEST-INFO | Main app process: exit 0
[task 2025-02-03T20:54:32.507Z] 20:54:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js | Application shut down (without crashing) in the middle of a test!
[task 2025-02-03T20:54:32.508Z] 20:54:32     INFO - TEST-INFO took 44538ms
[task 2025-02-03T20:54:32.509Z] 20:54:32     INFO - runtests.py | Application ran for: 0:02:21.007262

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc66db9c62a6
Part 1: add support for aria-label to moz-input-search r=tgiles
https://hg.mozilla.org/integration/autoland/rev/afc536969269
Part 2: add support for subheading slot to moz-page-nav r=reusable-components-reviewers,tgiles
https://hg.mozilla.org/integration/autoland/rev/f4b6924fcf66
Part 3: refactor header to heading, fix test_moz_page_nav spacing r=reusable-components-reviewers,tgiles

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bc66db9c62a6
https://hg.mozilla.org/mozilla-central/rev/afc536969269
https://hg.mozilla.org/mozilla-central/rev/f4b6924fcf66