1881767 - Replace about:addons navigation sidebar with moz-page-nav reusable component

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Hanna Jones [:hjones]]

kcochrane recently created a new moz-page-nav reusable component in bug 1850591. It is designed to standardize how we build navigation elements in in-content pages. It offers a number of accessibility improvements over the bespoke one written for about:addons (the heading for wayfinding, the notch to indicate the selected page), and has had a lot of recent attention from the UX / a11y teams. It will also have the added benefit of making about:addons cohesive with Firefox View, and with about:preferences once bug 1867385 is completed.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1881767 - Migrate about:addons categories-box to moz-page-nav reusable components. r?willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1881767 - Better alignment between the about:addons main view header and moz-page-nav primary header.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1881767 - Remove unused sidebar fluent strings from aboutAddons.ftl.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1881767 - Remove remaining use of the CategoryUtilities test helpers from the AddonManager mochitest-browser tests. r?willdurand!

Depends on D298528

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1881767 - Tweak browser_html_mlmodel_addons.js to unblock removing CategoriesBox workaround for test calling click on moz-page-nav-button elements. r?willdurand!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58630e1cb9d9
https://hg.mozilla.org/integration/autoland/rev/3567a8d87863
Migrate about:addons categories-box to moz-page-nav reusable components. r=willdurand,kcochrane,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/625fef885cf1
https://hg.mozilla.org/integration/autoland/rev/6c3a70e1e6e8
Better alignment between the about:addons main view header and moz-page-nav primary header. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/02ceae9337cb
https://hg.mozilla.org/integration/autoland/rev/fb6ebc77bd49
Remove unused sidebar fluent strings from aboutAddons.ftl. r=fluent-reviewers,flod
https://github.com/mozilla-firefox/firefox/commit/71694205b55f
https://hg.mozilla.org/integration/autoland/rev/31a91102e433
Remove remaining use of the CategoryUtilities test helpers from the AddonManager mochitest-browser tests. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/bc1688412e22
https://hg.mozilla.org/integration/autoland/rev/4bd27615ed5f
Tweak browser_html_mlmodel_addons.js to unblock removing CategoriesBox workaround for test calling click on moz-page-nav-button elements. r=willdurand

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2678ae6fce26
https://hg.mozilla.org/integration/autoland/rev/b3b4fe0bc452
Revert "Bug 1881767 - Tweak browser_html_mlmodel_addons.js to unblock removing CategoriesBox workaround for test calling click on moz-page-nav-button elements. r=willdurand" for causing mochitests failures in browser_commands.js.

Comment 8

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_commands.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-quickactions/browser_commands.js | test_pages - Uncaught exception in test - undefined - timed out after 50 tries.

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1881767 - Adjust browser_commands.js and browser_tab_refocus.js quickactions tests to the moz-page-nav based about:addons sidebar.

Depends on D299181

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Serban Stanca [:SerbanS] from comment #8)

Reverted this because it was causing mochitests failures in browser_commands.js.

I'm on it, I just attached a new patch with the small tweaks that this browser_commands.js needed to pass on the new moz-page-nav based sidebar (along with similar tweaks that browser_tab_refocus.js also needed).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a296da786746
https://hg.mozilla.org/integration/autoland/rev/5ac1960be581
Migrate about:addons categories-box to moz-page-nav reusable components. r=willdurand,kcochrane,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/0d6c9ee3e7ee
https://hg.mozilla.org/integration/autoland/rev/b8812d95a4ae
Better alignment between the about:addons main view header and moz-page-nav primary header. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/95f120bf513e
https://hg.mozilla.org/integration/autoland/rev/00c2a4c4594d
Remove unused sidebar fluent strings from aboutAddons.ftl. r=fluent-reviewers,flod
https://github.com/mozilla-firefox/firefox/commit/29c93eb0f410
https://hg.mozilla.org/integration/autoland/rev/6da8afa3c1f4
Remove remaining use of the CategoryUtilities test helpers from the AddonManager mochitest-browser tests. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/d6eb5e2adb56
https://hg.mozilla.org/integration/autoland/rev/a387a6e9e507
Tweak browser_html_mlmodel_addons.js to unblock removing CategoriesBox workaround for test calling click on moz-page-nav-button elements. r=willdurand
https://github.com/mozilla-firefox/firefox/commit/9b5a97391a84
https://hg.mozilla.org/integration/autoland/rev/30ad6f17a2b3
Adjust browser_commands.js and browser_tab_refocus.js quickactions tests to the moz-page-nav based about:addons sidebar. r=urlbar-reviewers,mak

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5ac1960be581
https://hg.mozilla.org/mozilla-central/rev/b8812d95a4ae
https://hg.mozilla.org/mozilla-central/rev/00c2a4c4594d
https://hg.mozilla.org/mozilla-central/rev/6da8afa3c1f4
https://hg.mozilla.org/mozilla-central/rev/a387a6e9e507
https://hg.mozilla.org/mozilla-central/rev/30ad6f17a2b3