1927379 - Adapt some generic Thunderbird error messages for dark mode in message pane

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, enhancement)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Bug 1715361 implemented "Dark UI: automatically convert light message content to dark", but the message pane has no dark mode, if S/MIME encoded messages could not be decoded. The resulting error message (generic from Thunderbird) seems to be forgotten for this first implementation. Not sure, if there are more of these generic messages, which have to be adapted.

Comment 1

[Richard Marti (:Paenglab)]

Alex, could you add such a message or at least a screenshot to know what error message this is?

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Screenshot 2024-10-28 122455.png

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Screenshot (focused by inspector with maybe helpfull div class)

Comment 4

[Richard Marti (:Paenglab)]

The error message is generated here: https://searchfox.org/comm-central/source/mail/extensions/smime/content/msgHdrViewSMIMEOverlay.js#357-390

I can't reproduce this error so I can't play with it. Maybe adding a <link rel="stylesheet" href="... /> in the <head> with a stylesheet that sets the colours could fix this issue.

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: testmail_smime.eml

With the attached test mail it should be possible to reproduce the error message.

Comment 6

[Richard Marti (:Paenglab)]

Yes I can reproduce the issue with your message -> fixed locally. I'm checking if there are other places which need the fix.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Bug 1927379 - Add a dark style to some info/error pages. r=#thunderbird-front-end-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70e6ef8903c3
Add a dark style to some info/error pages. r=aleca