1927612 - Backport folder compactor Glean probes to Telemetry

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Geoff Lankow (:darktrojan)]

Bug 1926152 added Glean probes to FolderCompactor. We want these on 128, so they'll need backporting to Telemetry.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1927612 - [ESR128] Add Telemetry data recording to FolderCompactor. r=#thunderbird-reviewers

Port of https://hg.mozilla.org/comm-central/rev/55388a9245ab62a546436e51d5ffcf6845be40cc, but with Telemetry instead of Glean.

Comment 2

[Corey Bryant]

Comment on attachment 9436294 [details]
Bug 1927612 - [ESR128] Add Telemetry data recording to FolderCompactor. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 3

[Kai Engert [:KaiE:]]

Attachment: D228401-merged-esr128.patch

Because the patches on comm-esr128 were applied in a different order, the phab patch didn't apply cleanly.

This is the manually merged patch.

Comment 4

[Daniel Darnell [:dandarnell]]

Thunderbird 128.4.3esr:
https://hg.mozilla.org/releases/comm-esr128/rev/145fdfb21d2e

Comment 5

[Geoff Lankow (:darktrojan)]

I want to close this bug but there is no data on the Telemetry server for these probes. I checked it's being recorded locally, so I don't know what's going on. Investigating…

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1927612 - Mark telemetry probes as collected on release channels. r=#thunderbird-reviewers

These probes have until now only been recorded on pre-release channels. That's not helpful.

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9438227 [details]
Bug 1927612 - Mark telemetry probes as collected on release channels. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): this bug
User impact if declined: no impact to users, just telemetry
Testing completed (on c-c, etc.): this patch only affects comm-esr128
Risk to taking this patch (and alternatives if risky): none

Comment 8

[Corey Bryant]

Comment on attachment 9438227 [details]
Bug 1927612 - Mark telemetry probes as collected on release channels. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 9

[Corey Bryant]

Thunderbird 128.4.4esr:
https://hg.mozilla.org/releases/comm-esr128/rev/e963642f77ed

Comment 10

[Corey Bryant]

Thunderbird 128.9.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/4204de2dd374e408a5ae93901f30962384dae509 (see bug 1954442 - reverted)
https://hg.mozilla.org/releases/comm-esr128/rev/c1f0a18e8699a452f5689ae677a5ea18f0ea8ab5 (see bug 1954442 - reverted)