1954442 - Uplift Thunderbird Glean to v128

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

This bug is about uplifting the Thunderbird Glean work to v128ESR (in favor of old style Telemetry).

On the mozilla-central side we need to uplift, in this order

• bug 1918118
• bug 1931277 glean-parser PR, then the rest of bug 1931277
• bug 1942797

Almost ready try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&selectedTaskRun=PFiCSt0aSoCvjJYeFbrU9A.0&revision=bd1f47c5b9bab397447d123a0b7f20199c31d3c5

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1954442 - Disable probes not on 128. r=tobyp

Comment 2

[Magnus Melin [:mkmelin]]

Not sure how we want the other patches. Grafting was for some of the a major pain.
Maybe it's easiest to import them directly from the try hg repo...

Comment 3

[Magnus Melin [:mkmelin]]

I set off a try build that should be pinning to the latest mozilla-esr128
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7153bf906893144514da871bbec92f6ecbd31b79

If things go well, I could push that series (minus the pinning) onto comm-esr128.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9472443 [details]
Bug 1954442 - Disable probes not on 128. r=tobyp

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Let's use this as approval for the series.
• User impact if declined: No glean
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: N/A
• Has the fix been verified in Beta?: N/A
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: The series listed
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 5

[Corey Bryant]

Comment on attachment 9472443 [details]
Bug 1954442 - Disable probes not on 128. r=tobyp

[Triage Comment]
Approved for esr128

Comment 6

[Magnus Melin [:mkmelin]]

Actually, I'll need to pin to the newer mozilla-esr128 as well.

Comment 7

[Magnus Melin [:mkmelin]]

Pushed: https://hg.mozilla.org/releases/comm-esr128/pushloghtml?changeset=e754942bb6572e12473b3f35020f84d0564c275a

Comment 8

[Corey Bryant]

Thunderbird 128.9.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/e754942bb6572e12473b3f35020f84d0564c275a (bug 1954442)
https://hg.mozilla.org/releases/comm-esr128/rev/9d6dd7034fdc7210ba696932d8542fbdefcb0aa0 (bug 1954442)
https://hg.mozilla.org/releases/comm-esr128/rev/f34518c2f28bd463a3c84c368dcacbc97384a555 (bug 1931277)
https://hg.mozilla.org/releases/comm-esr128/rev/1580a709e828fb86a24265616dce5b21e7ca43ba (bug 1945157)
https://hg.mozilla.org/releases/comm-esr128/rev/fa4bb08ca2ff92feae671a9e954aad6734caaa29 (bug 1945157 - reverted)
https://hg.mozilla.org/releases/comm-esr128/rev/f04042d3bdc0c2092f9052ced66cc5e59952ccd0 (bug 1926152)
https://hg.mozilla.org/releases/comm-esr128/rev/8022e646879fe52fcec2ca77daa4fcbb8bc4e01d (bug 1910837)
https://hg.mozilla.org/releases/comm-esr128/rev/fbef2a8e2dbbc471e263d002382b7b27f09489d3 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/20946b0b5e8bda1d46fe87af97d29771d8b0ce04 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/7a32b3ae9fdf37daca6c131eecd6ea743600059f (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/7b2220cb1700fce72c93d8aa0decca791987405a (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/892ad07f5dd9a949bde8d326d19754d606d643b1 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/6f227900feb66fdde406fef7fe93852c9fa951b1 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/fd9af55cfeecab83ccd8de632d344475616c552e (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/d55ca543a2d7f3b4a7711225e558226f0e4e94b5 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/d4780356bba51fd8813cf9aa779c1a08391eb26b (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/a35fb15bd7e18c7723f09e7fbfbd998dadf5ac3d (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/1198d52f3cc10fbe224ac889692c0ffef9859527 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/ddaa6d228e85d0d38496eefa35a2049f53c2f8f0 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/38d7bd0e95f3e8108cf5dc1b3cfecc3c327b6738 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/acd6e5e0c8037c92e5f65ebacdad91f82b829a78 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/318e32e751bfdc6e3d4d30341b6f3e77057aeb58 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/e3283d77d31609d0d4ae4b43c7606cb90f502ace (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/416602799dde132d392b1f02efa00813c5c78286 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/f0798965094488d7edc0a0169385e737ec692e6a (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/54510b9bc6701db48e43e7f4bc9ae9fbc2072050 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/50f4462d28cd76eef64401e80ad53240e76e19fa (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/1801a07513b7372581f0cf60067d901e9dd80724 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/41aa7ece507e6cfd94e6f19b04b1fcbca33679bd (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/db9bb10d86cd27a197eabb928d1fbfe4a2b67f63 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/c9a353096c613b48a9b00172640ecfff43653039 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/a7493aa1c668a8ec80343cadc89bf4916be306d1 (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/64124ca82235cd013909f3bca1b967600bba315b (bug 1899602)
https://hg.mozilla.org/releases/comm-esr128/rev/f05a0c0f3d6170e99df3be64691cc8cbdc634559 (bug 1927971 - reverted)
https://hg.mozilla.org/releases/comm-esr128/rev/ba70a619ef902b5327b8a09c7ef2f2054641d5f0 (bug 1926810 - reverted)
https://hg.mozilla.org/releases/comm-esr128/rev/4204de2dd374e408a5ae93901f30962384dae509 (bug 1927612 - reverted)
https://hg.mozilla.org/releases/comm-esr128/rev/c1f0a18e8699a452f5689ae677a5ea18f0ea8ab5 (bug 1927612 - reverted)

Comment 9

[Geoff Lankow (:darktrojan)]

Are you going to include newer changes too? E.g. bug 1929680.

edit: If (when) you do, please fix the typo mail.biff.alert.show_subjec.

Comment 10

[Geoff Lankow (:darktrojan)]

Daniel is taking care of this. Uplifts needed from bug 1929680, bug 1940674 and the follow-up from bug 1926152.