Open Bug 1927769 Opened 1 year ago Updated 8 months ago

Allow sessions.restore WebExtension API to understand tab groups

Categories

(Firefox :: Session Restore, task, P3)

task
Points:
2

Tracking

()

People

(Reporter: jswinarton, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-tabgrps-sessionstore])

No description provided.
Blocks: 1907100
See Also: → 1908422

Could you please add a few more details as to what's broken and/or missing? Do you think we need this fixed for the MVP?

Flags: needinfo?(jswinarton)
Whiteboard: [fidefe-tabgrps-sessionstore]

(In reply to Dão Gottwald [:dao] from comment #1)

Could you please add a few more details as to what's broken and/or missing? Do you think we need this fixed for the MVP?

This refers to this method: https://searchfox.org/mozilla-central/source/browser/components/sessionstore/SessionStore.sys.mjs#1015-1040

I mostly added this because I'm not sure what is necessary here, if anything, and I thought it would be good to discuss as a team if there's anything we need to do to support add-ons.

Flags: needinfo?(jswinarton)
Severity: -- → N/A
Points: --- → 2
Priority: -- → P3

Also calling out that the session restore forgetClosedTab method is used here: https://searchfox.org/mozilla-central/source/browser/components/extensions/parent/ext-sessions.js#147-161 and that this method implicitly assumes that the _closedTabs array is the same length as the closed tab counts reported by session restore. We may need to do some work here.

See Also: → 1940631
See Also: → 1965708
See Also: → 1968190
See Also: → 1979759
You need to log in before you can comment on or make changes to this bug.