1908422 - Implement closedGroups array

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P2)

Description

[Dão Gottwald [:dao]]

Each window gains a _closedGroups array. When a group is deleted it is moved there and its tabs moved into the group object as a tabs array property. Also update Recently Closed UI. Figure out how to handle recently closed tabs limit. Pull out _closedGroups array in deferred restore case.

Figma: https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping?node-id=8768-38810&t=jjhwvlOnvNiqqZ6b-0

Comment 1

[Jeremy Swinarton (PTO until 2026-04-06)]

Attachment: Bug 1908422: Add closedGroups to SessionRestore for tab groups r?dao,dwalker,sthompson

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e5edf53c876
Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers

Comment 3

[amarc]

Backed out for causing bc failures @ browser_tab_groups_a11y.js

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_a11y.js | Test timed out -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/307c830b0d2b
Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers

Comment 5

[Atila Butkovits]

Backed out changeset for causing failures at browser_tab_groups.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a93fc149b12e8284bf04d638fb44744500800bf7

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=307c830b0d2b9382d9c6ffd0c04b22b34b1a3429&selectedTaskRun=VBvl5Y3hQT24NLOIHVBK4A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=481831576&repo=autoland&lineNumber=40392

Comment 6

[Jeremy Swinarton (PTO until 2026-04-06)]

(In reply to Atila Butkovits from comment #5)

Backed out changeset for causing failures at browser_tab_groups.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a93fc149b12e8284bf04d638fb44744500800bf7

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=307c830b0d2b9382d9c6ffd0c04b22b34b1a3429&selectedTaskRun=VBvl5Y3hQT24NLOIHVBK4A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=481831576&repo=autoland&lineNumber=40392

Hi Atila,

I looked into the failure logs for this, but it seems to me that this is an intermittent that's not caused by this patch. While my patch does modify the tests in the file that failed, it was only to rename a DOM event, and the file otherwise had no changes. The failure is also reporting as intermittent on the treeherder link in your comment. Finally, looking at the intermittent failures report on this test file generally, I can see that the same error has been occurring in central since at least November 5. Based on this, I think this patch should land. Let me know if you think there's something I missed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/509317daff2d
Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/509317daff2d