1927940 - test_sync_auth_manager.js failing on comm-beta

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Geoff Lankow (:darktrojan)]

test_sync_auth_manager.js is failing on beta because of a missing default preference. The test shouldn't even really be running on beta, but it has been for ages so I'm not going to change that now.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1927940 - Set a default value of a preference on all channels to fix a test. r=#thunderbird-reviewers

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1927940 - Stop enabling MOZ_SERVICES_SYNC outside the nightly build. r=#thunderbuild

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e264b2100cae
Stop enabling MOZ_SERVICES_SYNC outside the nightly build. r=rjl

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f2f9469a9e68
follow-up - Fix formatting in mail/moz.configure. rs=linting DONTBUILD

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9434098 [details]
Bug 1927940 - Stop enabling MOZ_SERVICES_SYNC outside the nightly build. r=#thunderbuild

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: none
Testing completed (on c-c, etc.): just landed on comm-central but changes nothing there
Risk to taking this patch (and alternatives if risky): none, everything connected to sync is already disabled on beta

Comment 7

[Corey Bryant]

Comment on attachment 9434098 [details]
Bug 1927940 - Stop enabling MOZ_SERVICES_SYNC outside the nightly build. r=#thunderbuild

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 133.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/89503e332671
https://hg.mozilla.org/releases/comm-beta/rev/7ec34a1b016c

Comment 9

[Rob Lemley [:rjl]]

Packaging failures on beta:
package> error: $SRCDIR/comm/mail/installer/package-manifest.in:328: Missing file(s): bin/components/SyncComponents.manifest

Comment 10

[Rob Lemley [:rjl]]

Attachment: Bug 1927940 - Do not package SyncComponents without MOZ_SERVICES_SYNC. r=#thunderbird-reviewers

Comment 11

[Rob Lemley [:rjl]]

Comment on attachment 9434822 [details]
Bug 1927940 - Do not package SyncComponents without MOZ_SERVICES_SYNC. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1927940
User impact if declined: build packaging fails
Testing completed (on c-c, etc.): local beta build
Risk to taking this patch (and alternatives if risky):
worst case is another failed build..

Comment 12

[Corey Bryant]

Comment on attachment 9434822 [details]
Bug 1927940 - Do not package SyncComponents without MOZ_SERVICES_SYNC. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 133.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/a8853976dade

Comment 14

[Geoff Lankow (:darktrojan)]

Uh?! I didn't realise there was another bit. Should've done a Try run, sorry.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3109cfa37b1
Do not package SyncComponents without MOZ_SERVICES_SYNC. r=aleca

Comment 16

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6595d3d99a46
Backed out changeset a3109cfa37b1 due to test fails. r=backout

Comment 17

[Geoff Lankow (:darktrojan)]

Looks like we should use #ifdef NIGHTLY_BUILD instead of #ifdef MOZ_SERVICES_SYNC. I've come across it not being defined before and never really understood why.

Comment 18

[Rob Lemley [:rjl]]

I'd prefer to keep it MOZ_SERVICES_SYNC, as tying it to NIGHTLY_BUILD may cause issues for downstream builds.

Comment 19

[Geoff Lankow (:darktrojan)]

This needs to land again. I've checked it locally on central and beta this time.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e2c65b00c1ef
Do not package SyncComponents without MOZ_SERVICES_SYNC. r=aleca