1927994 - With pinned tabs, after opening tab group, this group's tabs' layout in tab bar is moved to left

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Aliko Tektov]

Attachment: Tab bar screenshot

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

I opened and closed different tabs, moved some tabs from and to groups. Then I clicked on tab group to show its tabs.

Actual results:

Tab group's tabs' layout in tab bar was moved to left, over other tabs.

Expected results:

Tabs should have been displayed on the right side after group's name.

Comment 1

[Aliko Tektov]

All the tab groups started to have broken layout after opening.

Comment 2

[Timea Zsoldos [:tzsoldos], Desktop QA]

Reproduced on Win 10 on latest Nightly Firefox 134.0a1, setting pref browser.tabs.groups.enabled to true, after grouping tabs and move them from original position, all the tabs groups started to have broken layout.
I will mark this issue to new.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Dão Gottwald [:dao]]

I've never seen this, and I'm not sure how to reproduce. :/ If you still see this, could you please provide exact steps to reproduce?

Comment 5

[Dão Gottwald [:dao]]

Hey Rares, can you reproduce this bug?

Comment 6

[Rares Doghi, Desktop QA]

I was able to reproduce this issue in our latest Nightly build 135.0a1 (2024-11-26) as well as our latest Beta 134.0b1.

Have a few tabs pinned and create a few Tab Groups.
Open a lot of new tabs.
Have the Tab groups as the first Tabs right after Pinned tabs and collapse the first few tab groups.
Pin a few more tabs.

Comment 7

[Rares Doghi, Desktop QA]

Attachment: PinStuff.mp4

Comment 8

[Stephen Thompson [:sthompson]]

Attachment: Bug 1927994 - do not allow pinned tabs to move inside tab groups r=dao,dwalker,jswinarton

There are a number of oddities that cropped up from pinned tabs moving into tab groups, e.g. when the first item in the tab strip is a tab group or when pinning a tab that's already in a tab group. This patch repairs those cases to ensure that pinned tabs stick to the beginning of the tab strip.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9e54d382aac
do not allow pinned tabs to move inside tab groups r=dao,tabbrowser-reviewers

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f9e54d382aac

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 135.0a1 (2024-12-08).

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sthompson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.