1943885 - Pinning first tab should ungroup it

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot 1

When you have a tab group and pin one of its tabs, behavior is a bit erratic:

• The first pinned tab seems to work (see attached screenshot).
• But as soon as you pin another tab from another group, then that tab gets detached from its group.
• If you add many tabs, so that the tab list scrolls, then the pinned tab gets completely inaccessible.

I'd expect either:

• Pinning a tab always "ungroups" it. A bit unfortunate since it might be useful to have a tab group in the pinned tab area, but maybe ok.
• Pinning a tab pins the whole group.

But I haven't thought too hard about this. In any case making the tab inaccessible seems clearly a bug.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Same set-up with many tabs open to make tab bar scrollable.

Note how the pinned tab is gone.

Comment 2

[David Chmelik]

I disagree: I always wanted to be able to pin some (not all) tabs in groups.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1943885 - Pinning first tab should ungroup it. r?dwalker,jswinarton

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62e03ac130ac
Pinning first tab should ungroup it. r=dwalker,tabbrowser-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/62e03ac130ac

Comment 6

[Mr. Beedell, Roke Julian Lockhart (RJLB)]

#c2

David, likewise: I literally have issues.chromium.org/issues/40937562 and 40937561 filed with Chromium for this. Would an FR to re-add this functionality in a non-buggy manner be acceptable?

Comment 7

[Dão Gottwald [:dao]]

(In reply to Mr. Beedell, Roke Julian Lockhart from comment #6)

#c2

David, likewise: I literally have issues.chromium.org/issues/40937562 and 40937561 filed with Chromium for this. Would an FR to re-add this functionality in a non-buggy manner be acceptable?

We have a few more edge cases to consider e.g. related to tab overflow (which Chrome doesn't have). So I don't know how realistic it is to come up with a solution here, and it's not clear to me what that solution might be, but with that being said, sure, we would consider a non-buggy implementation.