1928058 - ReferenceError: AddonManager is not defined after update to 134.0a1

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

While using mozregression I noticed this in the error console:

ReferenceError: AddonManager is not defined
    _onFirstWindowLoaded resource:///modules/MailGlue.sys.mjs:645
    observe resource:///modules/MailGlue.sys.mjs:435
    openTab chrome://messenger/content/mailTabs.js:118
    InterpretGeneratorResume self-hosted:1413
    AsyncFunctionNext self-hosted:800

This happens when the app is restarted for the first time after the update to 134.0a1. The error causes MailGlue._onFirstWindowLoaded to exit prematurely, so _scheduleStartupIdleTasks() doesn't run, which is also responsible for starting Gloda, so this may cause bug 1927088 comment 6.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1928058 - Fix small oversight from bug 1918951. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f3508e961ae5
Fix small oversight from bug 1918951. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

We should uplift asap. Hartmut, can you request it?

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9434208 [details]
Bug 1928058 - Fix small oversight from bug 1918951. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1918951
User impact if declined: User may experience weird errors (broken message context menu/multi-message view) when the app runs the first time after updating to 133 (!)
Risk to taking this patch (and alternatives if risky): Definitely riskier not to take it.

Comment 5

[Corey Bryant]

Comment on attachment 9434208 [details]
Bug 1928058 - Fix small oversight from bug 1918951. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Release Note Request (optional, but appreciated)
[Suggested wording]: Fixed: Global database didn't work immediately after updating to Thunderbird 133.

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 133.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/22046ba31543

Comment 8

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Are there any specific STR that QA could perform in order to reproduce the faulty behaviour(crash) on an affected build and properly verify and confirm that it is fixed?

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Install Beta 132. Let it update itself to 133 and restart. If there is no `ReferenceError: AddonManager is not defined' in the error console and the context menu works normally, this is fixed.