192837 - Freeze the rest of the DOM HTML interfaces

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

Some of the standard nsIDOMHTML* interfaces are already frozen, the rest should
be frozen too, now that the DOM HTML Level 2 spec is released. Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Freeze the rest.

Comment 2

[Asa Dotzler [:asa]]

Sure. Documentation change only, right? We should get this for 1.3 if possible. 

Comment 3

[Johnny Stenback (:jst)]

Attachment: Also freeze nsIDOMStyleSheetList while we're at it.

Yeah, comment changes only. Here's one more of the same...

Comment 4

[harishd]

Comment on attachment 114156 [details] [diff] [review]
Freeze the rest.

>Index: dom/public/idl/html/nsIDOMHTMLTableSectionElem.idl
>===================================================================

>+/**
>+ * The nsIDOMHTMLSelectElement interface is the interface to a [X]HTML

This should be nsIDOMHTMLTableSectionElement. no?

>+ * thead, tbody, and tfoot element.
>+ *
>+ * For more information on this interface please see
>+ * http://www.w3.org/TR/DOM-Level-2-HTML/
>+ *
>+ * @status FROZEN
>+ */
>+
> [scriptable, uuid(a6cf90b5-15b3-11d2-932e-00805f8add32)]
> interface nsIDOMHTMLTableSectionElement : nsIDOMHTMLElement
> {

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 114156 [details] [diff] [review]
Freeze the rest.

>+ * For more information on this interface please see
>+ * http://www.w3.org/TR/DOM-Level-2-HTML/

The spec doesn't have a trailing / on this URL.

>Index: dom/public/idl/html/nsIDOMHTMLBaseFontElement.idl
>===================================================================

Add "// Modified in DOM Level 2:" to size.

>Index: dom/public/idl/html/nsIDOMHTMLObjectElement.idl
>===================================================================

Do we want contentDocument to be readonly as in the spec?

>Index: dom/public/idl/html/nsIDOMHTMLOptionElement.idl
>===================================================================

Add "// Modified in DOM Level 2:" to defaultSelected and index
Do we want text to be readonly as in the spec?

>Index: dom/public/idl/html/nsIDOMHTMLSelectElement.idl
>===================================================================

Add "// Modified in DOM Level 2:" to length and options.
Document exceptions on length and add.

>Index: dom/public/idl/html/nsIDOMHTMLTableElement.idl
>===================================================================

Add "// Modified in DOM Level 2:" and exception documentation to caption,
tHead, tFoot, insertRow and deleteRow.

>Index: dom/public/idl/html/nsIDOMHTMLTableRowElement.idl
>===================================================================

Add "// Modified in DOM Level 2:" to rowIndex, sectionRowIndex, cells,
insertCell and deleteCell.
Document exceptions on insertCell and deleteCell.

>Index: dom/public/idl/html/nsIDOMHTMLTableSectionElem.idl
>===================================================================

Add "// Modified in DOM Level 2:" and exception documentation to insertRow and
deleteRow.

>Index: dom/public/idl/html/nsIDOMHTMLTextAreaElement.idl
>===================================================================

Add "// Modified in DOM Level 2:" to defaultValue.

Comment 6

[Johnny Stenback (:jst)]

Landed all the comment-only changes, the remaining changes that are not
restricted to comment changes remain, those are nsIDOMHTMLObjectElement,
nsIDOMHTMLOptionElement, and nsIDOMHTMLSelectElement.

Comment 7

[Juan José Mata]

EDT triage: plussing topembed nomination for API freeze.

The remaining interfaces are not targetted for 1.3final, are they?  Should we
open a new bug for them and close this fixed?

Comment 8

[Johnny Stenback (:jst)]

Attachment: Freeze the rest of our HTML DOM interfaces.

Comment 9

[Peter Van der Beken [:peterv]]

Comment on attachment 116835 [details] [diff] [review]
Freeze the rest of our HTML DOM interfaces.

>Index: dom/public/idl/html/nsIDOMHTMLOptionsCollection.idl
>===================================================================

>+ * Version: NPL 1.1/GPL 2.0/LGPL 2.1

MPL/GPL/LGPL please.

>+ * Contributor(s):
>+ *   Vidur Apparao <[e-mail]> (original author)
>+ *   Johnny Stenback <[e-mail]>

I thought you were Vidur now. Or am I mixing up your multiple personalities?
:-)

>Index: dom/public/idl/html/nsIDOMNSHTMLOptionElement.idl
>===================================================================
>+ * Version: NPL 1.1/GPL 2.0/LGPL 2.1

See above.

>+ * Contributor(s):
>+ *   Vidur Apparao <[e-mail]> (original author)
>+ *   Johnny Stenback <[e-mail]>

See above.

Comment 10

[Fabian Guisset]

Comment on attachment 116835 [details] [diff] [review]
Freeze the rest of our HTML DOM interfaces.

>Index: dom/public/idl/html/nsIDOMHTMLOptionsCollection.idl

>+#include "nsIDOMHTMLElement.idl"
>+
Is this include really necessary?

>Index: dom/src/base/nsDOMClassInfo.cpp
> 
>   DOM_CLASSINFO_MAP_BEGIN_NO_CLASS_IF(HTMLOptionCollection,
>                                       nsIDOMHTMLCollection)
>+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMHTMLOptionsCollection)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSHTMLOptionCollection)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMHTMLCollection)
>   DOM_CLASSINFO_MAP_END

I was wondering if it was still useful to write it this way.
HTMLOptionCollection used to be
a Mozilla extension but now there's a standard HTMLOptionsCollection. I checked
on google and
the only mention of HTMLOptionCollection is in an auto-generated table on
devedge.
Now that HTMLOptionsCollection has a class interface, why not rewrite it like
this:
DOM_CLASSINFO_MAP_BEGIN(HTMLOptionsCollection, nsIDOMHTMLOptionsCollection)
  DOM_CLASSINFO_MAP_ENTRY(nsIDOMHTMLOptionsCollection)
  DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSHTMLOptionCollection)
  DOM_CLASSINFO_MAP_ENTRY(nsIDOMHTMLCollection)
DOM_CLASSINFO_MAP_END

It's just a suggestion, I'm not sure it's what we're looking for...
In fact all this inconsistency HTMLOptionCollection vs HTMLOptionsCollection is
annoying :-)

Apart from that, r=fabian

Comment 11

[Johnny Stenback (:jst)]

Good catch Fabian. All suggested changes made and changes checked in. Marking FIXED.

Comment 12

[harishd]

Comment on attachment 114307 [details] [diff] [review]
Also freeze nsIDOMStyleSheetList while we're at it.

r=harishd