1928399 - Release channel should not open whatnew page

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P2)

Description

[Corey Bryant]

The Release channel shouldn't open a whatnew page.
See more at original issue at https://github.com/thunderbird/thunderbird-website/issues/683

By the way, it looks like we have a whatsnew url defined for beta as well in mail/config/whats_new_page.yml. Is that needed?

Comment 1

[Rob Lemley [:rjl]]

Remove lines 27-35 of that file.
Though once we have release notes for monthly, we might want it back? Comment it out maybe?

Comment 2

[Rob Lemley [:rjl]]

Actually, there's another way to do this that I think makes more sense.

in /comm/taskcluster/kinds/balrog/kind.yml, there's:

        update-no-wnp:
            by-release-type:
                nightly.*: false
                default: true

Let's change that so that the "release" release type is set to "false" like "nightly" is. That will change the Balrog update rules to point to the "-No-WNP" release blobs. The only difference with those is that the "updateLine" section will not include the whatsnew page in the showURL action.

"updateLine": [
    {
      "fields": {
        "detailsURL": "https://live.thunderbird.net/thunderbird/releasenotes?locale=%LOCALE%&version=132.0&channel=release",
        "type": "minor"
      },
      "for": {}
    },
    {
      "fields": {
        "actions": "showURL",
        "openURL": "https://live.thunderbird.net/thunderbird/whatsnew?locale=%LOCALE%&version=132.0&channel=release&oldversion=%OLD_VERSION%"
      },
      "for": {
        "channels": [
          "release",
          "release-localtest",
          "release-cdntest"
        ],
        "versions": [
          "<132.0"
        ]
      }
    }
  ]

This change can be made manually on the release channel now and fix this issue for current users. The code change is needed to make it permanent.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1928399 - Use -no-WNP release blobs on comm-release. r=#thunderbuild

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9435205 [details]
Bug 1928399 - Use -no-WNP release blobs on comm-release. r=#thunderbuild

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: will keep opening a 404'd url on major update
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
as requested. low risk, this is a minor configuration change to a code path used by nightly and FF devedition.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/82f9dc077e4f
Use -no-WNP release blobs on comm-release. r=dandarnell

Comment 6

[Corey Bryant]

Comment on attachment 9435205 [details]
Bug 1928399 - Use -no-WNP release blobs on comm-release. r=#thunderbuild

[Triage Comment]
Approved for beta

Comment 7

[Corey Bryant]

Thunderbird 133.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1c5ed3dd9545