1928424 - Change naming of closedInGroup and lastClosedTabGroupCount to avoid clashing with tab group functionality

Status: NEW

(Firefox :: Session Restore, task, P3)

Comment 1

[Jeremy Swinarton]

Attachment: Bug 1928424: Change naming of closedInGroup and lastClosedTabGroupCount to avoid clashing with tab group functionality

Comment 2

[Sam Foster [:sfoster] (he/him)]

Here's a STR for a case which this proposed change would impact:

• Enable "Open previous windows and tabs" in about:preferences
• Open 3 non-blank tabs (we have logic to ignore and not save "blank" tabs like about:newtab, about:home, about:blank for undo.
• Using shift+click, select 2 tabs, and right-click to "close 2 tabs".
• Restart the browser (File > Quit or ctrl+Q)
• When it starts back up, it should have restore any non-empty tabs still open before the restart. ctrl+shift+t to undo the last action - which was to close those 2 tabs.

ER:

• The 2 tabs that were closed before restart get restored in their original positions

AR:

• Only 1 tabs is restored.

To test for the upgrade case - where a session file saved with the old version is being restored by a build with this patch - you can follow the first steps with an older build, then copy the sessionstore.jsonlz4 from the profile directory into the profile directory of the build under test.