Closed
Bug 1928501
Opened 3 months ago
Closed 1 months ago
Update logic for where "Learn more" links are showin in common input helpers
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
135 Branch
Tracking | Status | |
---|---|---|
firefox135 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
Details
(Whiteboard: [recomp])
Attachments
(2 files)
In bug 1900122 we implemented a common input base class that we are using to refactor older input elements and create new reusable input elements. In an attempt to standardize how "Learn more" links are displayed we added logic so that the links would always show next to the label. Based on some feedback when refactoring moz-toggle
we are thinking the logic should actually be:
- if we have a label and a description, display the "Learn more" link next to the description
- if we only have a label, display the "Learn more" link next to the label
Updated•3 months ago
|
Assignee | ||
Comment 1•2 months ago
|
||
Assignee | ||
Comment 2•2 months ago
|
||
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d43f55d7c92
change learn more link position when input description is present r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/719d439e6f2d
Part 2: Reorganize input-common CSS for clarity r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/mozilla-central/rev/9d43f55d7c92
https://hg.mozilla.org/mozilla-central/rev/719d439e6f2d
Status: NEW → RESOLVED
Closed: 1 months ago
status-firefox135:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•