1931059 - Elements that extend MozBaseInputElement can have a visible description without a visible label

Status: REOPENED

(Toolkit :: UI Widgets, defect, P3)

Description

[Hanna Jones [:hjones]]

Attachment: moz-checkbox with a description and no label

Currently if you provide a description to one of our custom elements that extends MozBaseInputElement the description will render regardless of whether or not you also supply a label. This looks weird visually and is probably not ever desirable (see attachment). It should be a pretty simple change to only render the description when a label is present. We will also need to update some tests and add an additional test as part of this work.

Comment 1

[Mark Striemer [:mstriemer]]

This is an unfortunate consequence of attributes being optional, even though the label is not really optional. If this happens, then we should fix that in fluent or in the design, since the label should definitely be required

Comment 2

[Mark Striemer [:mstriemer]]

After further discussion it may be nice to warn developers here so it's more clear where to look. Reopening and attaching to a new metabug