Closed
Bug 1928510
Opened 1 year ago
Closed 1 year ago
Remove now-unused codepath related to debugging WebExtension via WebExtensionDescriptor.getTarget
Categories
(DevTools :: General, task)
DevTools
General
Tracking
(firefox134 fixed)
RESOLVED
FIXED
134 Branch
| Tracking | Status | |
|---|---|---|
| firefox134 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
Bug 1754452 implemented a new way of debugging WebExtension via the Watcher actor instead of via a unique Target fetched via Descriptor.getTarget.
We can remove a few functions thanks to this.
| Assignee | ||
Comment 1•1 year ago
|
||
WebExtensionTargetActor.getTarget is being removed and removes most of the now-useless
codebase involving connectToFrame and message manager.
This allows to simplify a bit the ParentProcessTargetActor which required
some tweaks to be subclassed correctly.
We can also remove the consoleAPIListenerOptions which was specific to
this special target actor retrieving all document's console messages.
Now each individual target actor, for each document will handle the messages distinctly.
Note that we weren't using WebExtensionDescriptorFront.connect.
Updated•1 year ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8170c986c851
[devtools] Remove now-unused WebExtensionTargetActor. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox134:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•