1932882 - [backward] Webextension remote debugging broken between 134 and 133

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Descottes [:jdescottes]]

When trying to debug a webextension running on Firefox 133 from Firefox 134, the toolbox is blank.

The logged exception is:

Exception while opening the toolbox Error: Missing webextension target actor front. TargetCommand did not notify it (yet?) to the descriptor Error: Missing webextension target actor front. TargetCommand did not notify it (yet?) to the descriptor

getTarget resource://devtools/client/fronts/descriptors/webextension.js:137
_createFirstTarget resource://devtools/shared/commands/target/target-command.js:546
startListening resource://devtools/shared/commands/target/target-command.js:484
open resource://devtools/client/framework/toolbox.js:957
open resource://devtools/client/framework/toolbox.js:1144
_createToolbox resource://devtools/client/framework/devtools.js:749
open resource://devtools/client/framework/toolbox.js:1146

Comment 1

[Julian Descottes [:jdescottes]]

Backing out Bug 1928510 fixes the issue.

Comment 2

[Julian Descottes [:jdescottes]]

Should we just backout Bug 1928510 and reland in 135? I assume we only need it to connect to 133?

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1928510

Comment 4

[Julian Descottes [:jdescottes]]

Discussed in meeting I will try to backout and see if everything looks fine.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1932882 - [devtools] Backed out Bug 1928510 to fix webextension backward compat

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 9439805 [details]
Bug 1932882 - [devtools] Backed out Bug 1928510 to fix webextension backward compat

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes debugging webextensions remotely from Firefox 134 to Firefox 133. Most likely this will impact users of DevEdition (or Beta) trying to remote debug their extensions on Firefox release.

We are not landing the fix in Nightly, because this is a backout of a cleanup patch, which removed the necessary backward compatibility glue a bit too early. It's fine to have it removed in Firefox 135, but not in 134. Therefore we'd like to only land this patch in beta.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just a hg backout of a cleanup patch, try is green and we manually tested that both regular webextension debugging and backward compat remote debugging were still working
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/11c6b0210a46

Comment 8

[Julian Descottes [:jdescottes]]

Verified fixed on 134.b2 closing