1928550 - url bar length incorrect in popup window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Alex J. Peterson Santos]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

Open a pop-up window in any website (tested with multiple websites). On Firefox Nightly 134.0a1

Actual results:

The URL text box in the address bar of the popup window has a fixed length, which is shorter than the horizontal width of the window.

If resizing the window's horizontal width to be smaller, the URL text box bar overlaps with other UI elements on the right side (i.e. the hamburger menu for Firefox settings).

Expected results:

The URL text box should have dynamically resized

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=13537ae67079d33202b6570bb5a61d4ee652fecb&tochange=aa2b4302bdccdbfd659158479d68c4f377237e6c

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1927111

:emilio, since you are the author of the regressor, bug 1927111, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Donal Meehan [:dmeehan]]

Tracking for Fx134.
The regressor Bug 1927111 is a blocker for Fx133 and we'll need an uplift of that for beta.
However, only after the issue here has been investigated.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox134 (nightly). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

The fix for the other regression will fix this too

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Actually not.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1928550 - Don't breakout on readonly urlbar. r=#urlbar-reviewers

This was a pre-existing issue that was only papered by chance.
this._toolbar is set before the early return for readonly urlbars, but
the ResizeObserver is only set up after it.

Be more explicit about when we allow breaking out of the container (and
effectively do it only for non-readonly urlbars).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8443d818a62
Don't breakout on readonly urlbar. r=urlbar-reviewers,dao

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/f8443d818a62

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9434946 [details]
Bug 1928550 - Don't breakout on readonly urlbar. r=#urlbar-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: needed if we want to uplift bug 1927111
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open DevTools, run window.open(".", "", "popup=true")
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial-ish fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9434946 [details]
Bug 1928550 - Don't breakout on readonly urlbar. r=#urlbar-reviewers

Approved for 133.0b6

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0952e1c25fe2

Comment 14

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-10-31 Nightly build on macOS 14.
The issue seems to be partially fixed on the latest nightly build, the urlbar correctly resizes when maximising the pop-up window, however, if resizing the pop-up window width, the Hamburger Menu still overlaps over the urlbar, as described in Comment 0.
Should I open a new bug for this specific scenario? Thank you.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Yes, that seems like a regression from bug 1921811.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

I filed bug 1929853 with a fix for that.

Comment 17

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you for the fast reply!
Verified as fixed on the latest Firefox Nightly 134.0a1 build on Windows 10, Ubuntu 22, macOS 14.
The fix has also been verified on Firefox 133.0b6(treeherder build) on Windows 10, Ubuntu 22, macOS 14.
Since the overlapping issue is being tracked in bug 1929853 and the pop-up window urlbar now correctly expands/resizes, will mark both 134 and 133 as verified.