1927111 - The address bar stays static during macOS full-screen animations once focused at least once

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Stuart Colville [:muffinresearch]]

STR Horizontal:

• On Nightly Mac 2024-10-25
• With horizontal tabs enabled
• Click to focus once on the address bar to show the suggest options. (When this happens before or after the next step doesn't seem to matter).
• Enable full-screen on the window.
• Move mouse to the top of the window trigger the animation

What happens:

• The addressbar stays static rather than moving with everything else and ends-up over the top of other parts of the UI such as the tabstrip.

What should happen:

• The addressbar would move with everything else.

See below for steps for vertical tabs and how that's different:

STR Vertical:

• On Nightly Mac 2024-10-25
• With vertical tabs enabled
• Click to focus once on the address bar to show the suggest options. (When this happens before or after the next step doesn't seem to matter).
• Enable full-screen on the window.
• Move mouse to the top of the window trigger the animation

What happens:

• The addressbar disappears behind other UI.

What should happen:

• The addressbar would move with everything else.

Screencast to follow...

Comment 1

[:Gijs (he/him)]

I bet this is some kind of interaction between bug 1921811 and the fullscreen animation... I will try to look at this if I find time today but I may not be able to.

Comment 2

[Stuart Colville [:muffinresearch]]

Attachment: Screen Recording 2024-10-25 at 13.24.53.gif

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah... So the popover urlbar needs to manually be updated, effectively, because for layout purposes it is outside of the toolbox.

Comment 4

[:Gijs (he/him)]

Emilio has suggested there may need to be a platform fix here so passing this to him.

Comment 5

[Sarah Clements [:sclements]]

I'm not sure if this should be considered more of an S2 so please bump it if you think so.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1927111 - Add support for ChromeOnly flush: false for GeometryUtils. r=#layout,#webidl

This will be useful for the front-end to replace
nsIDOMWindowUtils.getBoundsWithoutFlushing(), since I need content box
bounds.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1927111 - Don't rely on static position (top: auto) for urlbar position. r=dao,Gijs,sfoster

The static position of these boxes is not great to depend upon, see:

https://github.com/w3c/csswg-drafts/issues/9939

Right now, we are relying on the static pos to be properly set which is
going to go away, eventually, and it is bogus, because it doesn't update
if e.g. only transform changes.

Use getBoxQuads to get the content box bounds properly. Also, make
breakout position: absolute explicitly, to prevent confusion.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1927111 - Shift urlbar during macOS fullscreen animation. r=dao,Gijs,sfoster

See comment for sadness.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d634e06efb3
Add support for ChromeOnly flush: false for GeometryUtils. r=layout-reviewers,webidl,saschanaz,dshin

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0d634e06efb3

Comment 11

[Sarah Clements [:sclements]]

[Tracking Requested - why for this release]: Since this is affecting 133 we'll want to get this uplifted to beta.

Comment 12

[Sarah Clements [:sclements]]

Thanks for the help Emilio!

Comment 13

[Donal Meehan [:dmeehan]]

This is tracked as blocking for Fx133, it is reproducible for me without enabling horizontal tabs or the sidebar.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8afe68ed6509
Don't rely on static position (top: auto) for urlbar position. r=Gijs,sfoster,desktop-theme-reviewers,urlbar-reviewers,mak
https://hg.mozilla.org/integration/autoland/rev/b12f12db6d50
Shift urlbar during macOS fullscreen animation. r=Gijs,sfoster,urlbar-reviewers,mak

Comment 15

[Atila Butkovits]

Backed out for causing failures at browser_add_search_engine.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1051afb2d58b2809ea67901f7643829b08e1284b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b12f12db6d501b264eafda0b3858da6d6ad23455&selectedTaskRun=VEfctzkaSDCjU88s4d4M0w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=480333570&repo=autoland&lineNumber=8213

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Sheriffs mentioned this was also failing on windows

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as blocking firefox133 (beta). However, the bug still has low severity.

:cbellini, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75d799eb1f33
Don't rely on static position (top: auto) for urlbar position. r=Gijs,sfoster,desktop-theme-reviewers,urlbar-reviewers,mak
https://hg.mozilla.org/integration/autoland/rev/aa2b4302bdcc
Shift urlbar during macOS fullscreen animation. r=Gijs,sfoster,urlbar-reviewers,mak

Comment 19

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/75d799eb1f33
https://hg.mozilla.org/mozilla-central/rev/aa2b4302bdcc

Comment 23

[Donal Meehan [:dmeehan]]

Adding a note for the context of users hitting this bug in Fx133:

• This has been fixed in Nightly for Fx134, however the fix introduced several regressions.
• We aim to either fix those regressions and uplift everything to beta for Fx133 OR backout Bug 1921811 from beta for Fx133.

Comment 24

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 133.0a1 (2024-10-25) on macOS 15.1 by following the STR from Comment 0, and it is easily reproducible without enabling horizontal/vertical tabs as Donal mentioned in Comment 13.

This issue is fixed on Firefox 134.0a1 (2024-11-04) on the same system.

Comment 26

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9433386 [details]
Bug 1927111 - Add support for ChromeOnly flush: false for GeometryUtils. r=#layout,#webidl

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: regression fix
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: Bug 1928550, Bug 1928255
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Even though this change is a bit scary, the final state with the other two bugs is not too different from the current beta code, so I think it's worth a try.
• String changes made/needed: none
• Is Android affected?: No

Comment 27

[Donal Meehan [:dmeehan]]

Comment on attachment 9433386 [details]
Bug 1927111 - Add support for ChromeOnly flush: false for GeometryUtils. r=#layout,#webidl

Rejecting beta uplift request, since this already rode the train to beta with Fx133

Comment 28

[Donal Meehan [:dmeehan]]

Comment on attachment 9433387 [details]
Bug 1927111 - Don't rely on static position (top: auto) for urlbar position. r=dao,Gijs,sfoster

Approved for 133.0b6

Comment 29

[Donal Meehan [:dmeehan]]

Comment on attachment 9433388 [details]
Bug 1927111 - Shift urlbar during macOS fullscreen animation. r=dao,Gijs,sfoster

Approved for 133.0b6

Comment 30

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/03ff18578c1c
https://hg.mozilla.org/releases/mozilla-beta/rev/f9720ac7891c

Comment 31

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #18)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75d799eb1f33
Don't rely on static position (top: auto) for urlbar position.
r=Gijs,sfoster,desktop-theme-reviewers,urlbar-reviewers,mak
https://hg.mozilla.org/integration/autoland/rev/aa2b4302bdcc
Shift urlbar during macOS fullscreen animation.
r=Gijs,sfoster,urlbar-reviewers,mak

Perfherder has detected a talos performance change from push 75d799eb1f33254be20ff86f0776133c89e4c9ae.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
15%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	22.81 -> 19.34
15%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	22.67 -> 19.37
5%	tresize	windows11-64-shippable-qr	e10s fission stylo webrender-sw	5.17 -> 4.90
3%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender	21.29 -> 20.59
3%	tart	windows11-64-shippable-qr	e10s fission stylo webrender	1.76 -> 1.71
3%	tresize	windows11-64-shippable-qr	e10s fission stylo webrender	4.68 -> 4.55

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42469

For more information on performance sheriffing please see our FAQ.

Comment 32

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that this issue is fixed on Firefox 133.0b6 (Treeherder build) on macOS 14.7.