1929190 - QM: Temporary origin is not initialized if a previous initialization attempt failed

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P1)

Description

[Jan Varga [:janv]]

https://searchfox.org/mozilla-central/rev/1bc0601cc5b3d4c3919d220acbe248221ebce035/dom/quota/ActorsParent.cpp#6085-6104

    QM_TRY_INSPECT(const bool& created, EnsureOriginDirectory(*directory));

    if (created) {
      const int64_t timestamp = PR_Now();

      FullOriginMetadata fullOriginMetadata =
          FullOriginMetadata{aOriginMetadata,
                             /* aPersisted */ false, timestamp};

      AddTemporaryOrigin(fullOriginMetadata);

      // Only creating .metadata-v2 to reduce IO.
      QM_TRY(MOZ_TO_RESULT(CreateDirectoryMetadata2(*directory, timestamp,
                                                    /* aPersisted */ false,
                                                    aOriginMetadata)));

      // Don't need to traverse the directory, since it's empty.
      InitQuotaForOrigin(fullOriginMetadata, ClientUsageArray(),
                         /* aUsageBytes */ 0);
    }

The case when the origin directory already exists (created by a previous failed initialization) needs to be handled.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1929190 - QM: Modify test_initializeTemporaryOrigin_failure.js to allow running multiple subtests; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1929190 - QM: Add a disabled subtest for a failure during temporary origin initialization; r=#dom-storage

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1929190 - QM: Initialize temporary origin even if a previous initialization attempt failed; r=#dom-storage

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e402a74f82c7
QM: Modify test_initializeTemporaryOrigin_failure.js to allow running multiple subtests; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/b7fdcfd96d84
QM: Add a disabled subtest for a failure during temporary origin initialization; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/6c85fec070ed
QM: Initialize temporary origin even if a previous initialization attempt failed; r=dom-storage-reviewers,asuth

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e402a74f82c7
https://hg.mozilla.org/mozilla-central/rev/b7fdcfd96d84
https://hg.mozilla.org/mozilla-central/rev/6c85fec070ed

Comment 6

[Jan Varga [:janv]]

Comment on attachment 9436859 [details]
Bug 1929190 - QM: Initialize temporary origin even if a previous initialization attempt failed; r=#dom-storage

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Theses patches are meant to fix a top crash
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1927723 and bug 1928092 (patches for all 3 bugs D227198 - D228670 need to land together, 10 patches in total)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): I think the risk is rather low despite the number of patches. Most of them are just about providing new testing infrastructure and new tests.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9436859 [details]
Bug 1929190 - QM: Initialize temporary origin even if a previous initialization attempt failed; r=#dom-storage

Approved for 133.0b9

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/10d73b6a411f
https://hg.mozilla.org/releases/mozilla-beta/rev/20168670d7d3
https://hg.mozilla.org/releases/mozilla-beta/rev/6b117bed252a