[spike] investigate current setup of toolbar's tab count icon
Categories
(Fenix :: Toolbar, task, P3)
Tracking
(Not tracked)
People
(Reporter: jmahon, Assigned: petru)
References
Details
(Whiteboard: [fxdroid][group3])
See Bug 1890717 for more context. This should be timeboxed to no more than half of a day.
|
||
Updated•4 months ago
|
|
||
Comment 1•4 months ago
|
||
Bug 1890717 is an existing bug and thus doesn't need to block releasing the new toolbar design.
Time box for 1 day.
Expectation is that there will be potential bugs from Beta release in the next 2 weeks.
|
Assignee | |
Updated•2 months ago
|
|
|
Assignee | |
Comment 3•2 months ago
|
||
I can reproduce the issue with the tab counter text being misaligned vertically but not horizontally.
This seems to happen because of this bottom padding used from when the tab counter was first implemented - 6 years ago.
The issue doesn't seem to affect the Compose implementation for a tab counter](https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/TabCounter.kt).
As a proposed workaround, instead of using brittle padding updates to try to position the infinite symbol where we want
We can use an svg with the infinite symbol drawable always centered in the tab counter box.
Description
•