1929956 - [Toolbar Redesign] Empty tab counter displayed when swiping to switch tabs on Samsung GalaxyZ Fold 4 (Android 13) and phone devices in landscape mode

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Delia Pop (Android QA)]

Steps to reproduce

1. Open a few tabs.
2. Swipe on the toolbar to switch tabs.
3. Observe the Tab counter.

Expected behavior

The number of tabs remains displayed when switching tabs.

Actual behavior

The tab counter is displayed empty when switching tabs.

Device information

• Firefox version: Nightly 134.0a1 from 11/06
• Android device model/Android OS version: reproduced with Samsung GalaxyZ Fold 4 (Android 13) in both orientations unfolded, and phone devices only in landscape mode (Samsung Galaxy S22 Ultra (Android 14))

Any additional information?

Not reproducible with the old toolbar.

Comment 1

[Delia Pop (Android QA)]

Attachment: media_20241107_211613_2927573386655054464.mp4

Comment 2

[Channing]

Beta blocker.

Comment 3

[Zac McKenney [:zmckenney]]

I can reproduce on a Pixel Fold but I also tested against a Samsung Galaxy S24 in portrait and landscape which never reproduces. This is a minor visual issue for foldables and tablets that only occurs when the user is swiping between tabs and shows correctly once settled. I don't think this deserves blocking status for Beta or Release and should be moved to followup work.

Channing, since you're out this week I'm going to move this to the followup work meta but lets discuss and move appropriately if this is a bigger concern to you.

Comment 4

[Channing]

(In reply to Zac McKenney [:zmckenney] from comment #3)

I can reproduce on a Pixel Fold but I also tested against a Samsung Galaxy S24 in portrait and landscape which never reproduces. This is a minor visual issue for foldables and tablets that only occurs when the user is swiping between tabs and shows correctly once settled. I don't think this deserves blocking status for Beta or Release and should be moved to followup work.

Channing, since you're out this week I'm going to move this to the followup work meta but lets discuss and move appropriately if this is a bigger concern to you.

I agree, we can move to follow-up work.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1929956 - Use an actual TabCounter in previews of landscape tabs with navbar enabled r=#android-reviewers

This allows to set the current tabs count to be shown.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dff429d151c
Use an actual TabCounter in previews of landscape tabs with navbar enabled r=android-reviewers,harrisono

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1dff429d151c

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Delia Pop (Android QA)]

Attachment: media_20250115_101331_3847438430584639626.mp4

Verified as fixed in latest Nightly 136.0a1 from 01/15. The number of tabs remains displayed when switching tabs.
Tested with Samsung GalaxyZ Fold 4 (Android 14), Samsung Galaxy A53 5G (Android 14) and Google Pixel 8 Pro (Android 14).

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9446106 [details]
Bug 1929956 - Use an actual TabCounter in previews of landscape tabs with navbar enabled r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Missing tab counter when swiping tabs in landscape.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On a phone in landcape mode:

• Open a few tabs.
• Swipe on the toolbar to switch tabs.
• Observe the Tab counter.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, for only tab previews (when changing tabs), validated by QA in Nightly.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9446106 [details]
Bug 1929956 - Use an actual TabCounter in previews of landscape tabs with navbar enabled r=#android-reviewers

Approved for 135.0b6.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/9bad54f58813

Comment 14

[Delia Pop (Android QA)]

Verified in Beta 135.0b6 with Samsung GalaxyZ Fold 4 (Android 14), Google Pixel 6 (Android 15), Realme C35 (Android 12) and Xiaomi Redmi 9C NFC (Android 10).