1929474 - Decide whether, and document why, to check for Win11's tablet mode where we check for Win10's

Status: RESOLVED FIXED

(Core :: Widget: Win32, task, P3)

Description

[Ray Kraesig [:rkraesig]]

Following bug 1819421, we should be able to detect tablet mode on Windows 11. As Win10's tablet mode and Win11's tablet mode share little in common save the name, however, we have not automatically done so for Win11 where we did for Win10.

We should go through our existing uses of tablet-mode detection, determine which of them we should be done on Windows 11, and document why or why not.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1929474 - [1/2] Fix Win10 tablet-mode hiding of close-button r?#win-reviewers,Gijs

The simplification of browser.css in bug 1844242 caused the close-button
to be hidden in tablet mode alongside the window-resizing buttons.
Revert that change's effect, and add documentation.

Comment 2

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1929474 - [2/2] Document (some) other uses of Win10 tablet mode r?#win-reviewers

Document remaining uses of Win10 tablet-mode detection which do not fall
under other bugs.

In particular, we leave alone:

• IsTabletDevice in WinUtils.cpp. This falls under bug 1735765.
• Uses in WinIMEHandler.{h,cpp}. These fall under bug 1929630.

No functional changes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aee01356e7f
[1/2] Fix Win10 tablet-mode hiding of close-button  r=desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/9775634e2d74
[2/2] Document (some) other uses of Win10 tablet mode  r=win-reviewers,firefox-desktop-core-reviewers ,handyman,mossop

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0aee01356e7f
https://hg.mozilla.org/mozilla-central/rev/9775634e2d74