1929968 - Ensure the search unit tests use add_setup correctly

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Stephanie Cunnane [:scunnane]]

At least one of the tests in browser/components/search/test/unit puts test setup code inside an add_task call, rather than an add_setup call.
There are at least 2 reasons this isn't a good idea:

1. add_setup is more explicit and semantically correct
2. When adding an .only() call to a task to run that task in isolation, the setup code will not be run at all if it's inside an add_task call, whereas it would be run if it were inside an add_setup call.

We need to fix test_urlTelemetry.js and check the other unit tests for the same issue.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1929968 - Ensure the search unit tests use add_setup correctly. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c85c2eba66d
Ensure the search unit tests use add_setup correctly. r=search-reviewers,jteow

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c85c2eba66d